Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Automate cherry-pick of PRs from next -> master #11382

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Dec 12, 2023

This might be useful for the PRs that need to be cherry-picked to master during the alpha and beta phases of development, while we are using the next branch as the source of truth.

Tested the workflow on a test repo, and it seems to work as expected!

@MBilalShafi MBilalShafi added the core Infrastructure work going on behind the scenes label Dec 12, 2023
@mui-bot
Copy link

mui-bot commented Dec 12, 2023

Deploy preview: https://deploy-preview-11382--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 80d7eb5

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initiative! 💯

.github/workflows/cherry-pick-next-to-master.yml Outdated Show resolved Hide resolved
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MBilalShafi!

@MBilalShafi MBilalShafi merged commit 4cf9199 into mui:next Dec 13, 2023
17 checks passed
@MBilalShafi MBilalShafi deleted the workflow/auto-cherry-pick-to-master branch December 13, 2023 13:25
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 19, 2023

It's great to see 👍


Regarding the new GitHub Action, I think that we need to fix the 4 securities regressions: #11468. @MBilalShafi could you fix them? Thanks


In general a few rules around GitHub actions securities: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions (I couldn't spot anything wrong for us)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants