Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] perf: remove querySelector call #12229

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented Feb 27, 2024

The cell checkbox renderer is calling .querySelector via an API function on each render.

@romgrk romgrk added performance component: data grid This is the name of the generic UI component, not the React module! labels Feb 27, 2024
@mui-bot
Copy link

mui-bot commented Feb 27, 2024

Deploy preview: https://deploy-preview-12229--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 2f5b830

@romgrk romgrk enabled auto-merge (squash) February 27, 2024 17:03
@romgrk romgrk merged commit 4745246 into mui:next Feb 28, 2024
17 checks passed
@romgrk romgrk deleted the perf-no-query-selector branch February 28, 2024 04:49
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants