Updated shinyngs containers and nftest snaps #7323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nf-test for validatefomcomponents depends on the approval of this PR: nf-core/test-datasets#1465 |
grst
approved these changes
Jan 17, 2025
| @@ -15,8 +15,8 @@ process SHINYNGS_APP { | |||
|
|
|||
| conda "${moduleDir}/environment.yml" | |||
| container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ? | |||
| 'https://depot.galaxyproject.org/singularity/r-shinyngs:2.0.0--r43hdfd78af_0' : | |||
| 'biocontainers/r-shinyngs:2.0.0--r43hdfd78af_0' }" | |||
| 'https://community-cr-prod.seqera.io/docker/registry/v2/blobs/sha256/97/971684ed03cda2689eea7db9e7f2ee74d079ddd74e3a3baac31e958eea6feb0e/data' : | |||
There was a problem hiding this comment.
Nice- was going to suggest this
| @@ -2,4 +2,5 @@ channels: | |||
| - conda-forge | |||
| - bioconda | |||
| dependencies: | |||
| - bioconda::r-shinyngs=2.0.0 | |||
| - bioconda::r-shinyngs=2.1.0 | |||
| - conda-forge::r-base=4.4.2 | |||
There was a problem hiding this comment.
I assume this pin is there to fix the snapshots.
Actually, I think we should just take the R version out of the version outputs from the modules. I hadn't appreciated when I wrote the modules that it would be disruptive, and I don't think there's a good reason to pin R otherwise.
We will in due course have lockfiles in nf-core to cover the real use case for this sort of thing.
nschcolnicov
force-pushed
the
bump_shinyngs_2.1.0
branch
from
cfc5748 to
5cf46fe
Compare
pinin4fjords
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #XXX
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda