-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix G7 plist File State Management #376
Conversation
Co-Authored-By: avouspierre <pn.lagarde@gmail.com>
Co-Authored-By: avouspierre <pn.lagarde@gmail.com>
Co-Authored-By: avouspierre <pn.lagarde@gmail.com>
StatusSuccessful tests ConfigurationI did this testing using dnzxy/fix/trio-g7-statemanagement, commit
G7 Sensor IdentifiersI am wearing two G7 sensors identified as:
Method to swap sensors without losing themThanks to @bjorkert for this method.
Behavior after swap sensorOnce Dexcom G7 app pairs with the designated sensor, monitor Trio while Loop reports its glucose reading in the dynamic island.
CGMManagetState.plist file with 2 different G7 sensorsBinary versions of the 2 plist files are in this zip file: |
The other thing I noted while testing this code was that once it connected to the G7 sensor, the CGMManagerState.plist updates the timestamp every time a CGM reading comes in. So it always has the most up-to-date information from the app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked the code and confirm no regressive bug for others CGM
@dnzxy Is it not wise to put the detached state into it own PR? Thats cleaner to search if ever needed to. At least put it in the title if we leave it in here |
It is also not required for testing of this PR, as it is on a branch. So it can safely be removed from here. |
As per request (@Sjoerd-Bo3, @bjornoleh) removed the capture build fix and opened a distinct PR (#378) for it. @marionbarker and @avouspierre, please re-approve the PR due to the changes. |
4d4c6b4
to
37f2e7c
Compare
StatusSuccessful test Steps Taken
Repeat the test from #376 (comment) This time, transition from Sensor 2 (DXCM3g) to Sensor 1 (DXCMJd).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a recheck and deployment with G6 successfully.
StatusSuccess More Testing
Build dev:
Sensor Swap with dev:
The CGMManagerState.plist file does not include the DXCMJd as was seen with the code from this PR. This screenshot is dated 07:39, while dev build was on phone. Build fix/trio-g7-statemanagement
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the trick also worked for me, will make definive reciew once normal change is coming up.
Went through a standard G7 switch from old sensor to new sensor. Successful with no manual interventions. Started new sensor on Dexcom G7 app, and Trio saw the new sensor on its own. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in vivo successfully.
Tested successfully in vivo. |
Transition to new sensor in vivo success. Id in plist file found. |
Fix G7 plist File State Management
Addresses #354 and handles glucose source changes so that the binary file is properly updated, solving an issue where Trio reverts back to old G7 transmitter IDs.
Additionally, this PR also holds a small fix by @bjorkert to be able to build Trio when the code base sits at a tag or a detached head.