process: add threadCpuUsage #56467
process: add threadCpuUsage #56467
Conversation
|
Review requested:
|
nodejs-github-bot
added
c++
github-actions
bot
removed
the
request-ci
|
What about moving the platform dependent code to libuv? Maybe taking libuv/libuv#3120 to the finish line would be a good idea. |
| @@ -148,6 +149,46 @@ function wrapProcessMethods(binding) { | |||
| }; | |||
| } | |||
|
|
|||
| const threadCpuValues = new Float64Array(2); | |||
There was a problem hiding this comment.
I recommend moving this to C++ side and updating it. A similar implementation exist in node url
There was a problem hiding this comment.
Will look it up. Thanks.
There was a problem hiding this comment.
I tried to look it up in the code but I couldn't find it.
Do you mind linking a reference to the similar implementation so I can check it out?
| // | ||
| // Returns those values as Float64 microseconds in the elements of the array | ||
| // passed to the function. | ||
| static void ThreadCPUUsage(const FunctionCallbackInfo<Value>& args) { |
There was a problem hiding this comment.
Nit: we can add a fast api call for this as well.
There was a problem hiding this comment.
I see. I will see what I can do about it.
There was a problem hiding this comment.
I looked at the documentation but I'm unsure on how to add Fast API to a function returning a complex data structure. Can you give some hints?
| // Replace the native function with the JS version that calls the native | ||
| // function. |
There was a problem hiding this comment.
Why don't we just implement the whole thing in C++? I’m a bit confused about this particular comment.
There was a problem hiding this comment.
Well, two reasons:
- I'm not totally familiar with C++ :)
- I want to keep the most parts we can in JS so that will be easier for a bigger chunk of contributors to chime in.
| if (prevValue) { | ||
| if (!previousValueIsValid(prevValue.user)) { | ||
| validateObject(prevValue, 'prevValue'); | ||
|
|
||
| validateNumber(prevValue.user, 'prevValue.user'); | ||
| throw new ERR_INVALID_ARG_VALUE.RangeError('prevValue.user', | ||
| prevValue.user); | ||
| } | ||
|
|
||
| if (!previousValueIsValid(prevValue.system)) { | ||
| validateNumber(prevValue.system, 'prevValue.system'); | ||
| throw new ERR_INVALID_ARG_VALUE.RangeError('prevValue.system', | ||
| prevValue.system); | ||
| } | ||
| } |
There was a problem hiding this comment.
It seems a lot of this functionality can be removed if we move the implementation to cpp?
There was a problem hiding this comment.
See above. :)
Anyway, we would have to perform the validation in the C++ side anyway, isn't it?
I'm sorry but I have very limited bandwidth lately. Trying to contribute to a codebase I never already did to it's not feasible for me. Once this lands everyone is absolutely welcome to port this to libuv. |
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
if that PR is orphaned, I can work on that one. Can I @jasnell? |
|
@juanarbol Ok, I'll pause on this until you update me about libuv PR. Thanks for taking care of that! |
There we go libuv/libuv#4666 |
|
Amazing! Keep up posted when this is released in libuv so I can update the dependencies and make this PR much leaner :) Do you have an approximate ETA? |
This PR add the
threadCpuUsagemethod toprocess.The method works exactly like
cpuUsagebut it returns thread specific metrics.This is already implemented (by me :)) in user-land in
https://www.npmjs.com/package/thread-cpu-usage.The PR is currently a draft as I'm gonna use the CI to see which platform don't support this. I'll add documentation updates once this is solved.