Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: add threadCpuUsage #56467

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/internal/bootstrap/node.js
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ const rawMethods = internalBinding('process_methods');
process.loadEnvFile = wrapped.loadEnvFile;
process._rawDebug = wrapped._rawDebug;
process.cpuUsage = wrapped.cpuUsage;
process.threadCpuUsage = wrapped.threadCpuUsage;
process.resourceUsage = wrapped.resourceUsage;
process.memoryUsage = wrapped.memoryUsage;
process.constrainedMemory = rawMethods.constrainedMemory;
Expand Down
42 changes: 42 additions & 0 deletions lib/internal/process/per_thread.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ function nop() {}
function wrapProcessMethods(binding) {
const {
cpuUsage: _cpuUsage,
threadCpuUsage: _threadCpuUsage,
memoryUsage: _memoryUsage,
rss,
resourceUsage: _resourceUsage,
Expand Down Expand Up @@ -148,6 +149,46 @@ function wrapProcessMethods(binding) {
};
}

const threadCpuValues = new Float64Array(2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend moving this to C++ side and updating it. A similar implementation exist in node url

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will look it up. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to look it up in the code but I couldn't find it.
Do you mind linking a reference to the similar implementation so I can check it out?


// Replace the native function with the JS version that calls the native
// function.
Comment on lines +154 to +155
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we just implement the whole thing in C++? I’m a bit confused about this particular comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, two reasons:

  1. I'm not totally familiar with C++ :)
  2. I want to keep the most parts we can in JS so that will be easier for a bigger chunk of contributors to chime in.

function threadCpuUsage(prevValue) {
// If a previous value was passed in, ensure it has the correct shape.
if (prevValue) {
if (!previousValueIsValid(prevValue.user)) {
validateObject(prevValue, 'prevValue');

validateNumber(prevValue.user, 'prevValue.user');
throw new ERR_INVALID_ARG_VALUE.RangeError('prevValue.user',
prevValue.user);
}

if (!previousValueIsValid(prevValue.system)) {
validateNumber(prevValue.system, 'prevValue.system');
throw new ERR_INVALID_ARG_VALUE.RangeError('prevValue.system',
prevValue.system);
}
}
Comment on lines +158 to +172
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a lot of this functionality can be removed if we move the implementation to cpp?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above. :)
Anyway, we would have to perform the validation in the C++ side anyway, isn't it?


// Call the native function to get the current values.
_threadCpuUsage(threadCpuValues);

// If a previous value was passed in, return diff of current from previous.
if (prevValue) {
return {
user: threadCpuValues[0] - prevValue.user,
system: threadCpuValues[1] - prevValue.system,
};
}

// If no previous value passed in, return current value.
return {
user: threadCpuValues[0],
system: threadCpuValues[1],
};
}

// Ensure that a previously passed in value is valid. Currently, the native
// implementation always returns numbers <= Number.MAX_SAFE_INTEGER.
function previousValueIsValid(num) {
Expand Down Expand Up @@ -263,6 +304,7 @@ function wrapProcessMethods(binding) {
return {
_rawDebug,
cpuUsage,
threadCpuUsage,
resourceUsage,
memoryUsage,
kill,
Expand Down
9 changes: 7 additions & 2 deletions src/node_errors.h
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,9 @@ void OOMErrorHandler(const char* location, const v8::OOMDetails& details);
V(ERR_WASI_NOT_STARTED, Error) \
V(ERR_ZLIB_INITIALIZATION_FAILED, Error) \
V(ERR_WORKER_INIT_FAILED, Error) \
V(ERR_PROTO_ACCESS, Error)
V(ERR_PROTO_ACCESS, Error) \
V(ERR_THREAD_CPU_USAGE_UNSUPPORTED, Error) \
V(ERR_THREAD_CPU_USAGE_FAILED, Error)

#define V(code, type) \
template <typename... Args> \
Expand Down Expand Up @@ -214,7 +216,10 @@ ERRORS_WITH_CODE(V)
V(ERR_WORKER_INIT_FAILED, "Worker initialization failure") \
V(ERR_PROTO_ACCESS, \
"Accessing Object.prototype.__proto__ has been " \
"disallowed with --disable-proto=throw")
"disallowed with --disable-proto=throw") \
V(ERR_THREAD_CPU_USAGE_UNSUPPORTED, \
"process.threadCpuUsage is not available on this platform") \
V(ERR_THREAD_CPU_USAGE_FAILED, "Failed to get thread CPU usage")

#define V(code, message) \
inline v8::Local<v8::Object> code(v8::Isolate* isolate) { \
Expand Down
67 changes: 67 additions & 0 deletions src/node_process_methods.cc
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,71 @@ static void CPUUsage(const FunctionCallbackInfo<Value>& args) {
fields[1] = MICROS_PER_SEC * rusage.ru_stime.tv_sec + rusage.ru_stime.tv_usec;
}

// ThreadCPUUsage use system dependent implementation to get the current thread
// cpu times:
//
// - On Unix, it uses getrusage(2) with RUSAGE_THREAD.
// - On macOS, it uses thread_info(2) with THREAD_BASIC_INFO.
// - On Windows, it uses GetThreadTimes(2).
//
// Returns those values as Float64 microseconds in the elements of the array
// passed to the function.
static void ThreadCPUUsage(const FunctionCallbackInfo<Value>& args) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we can add a fast api call for this as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I will see what I can do about it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the documentation but I'm unsure on how to add Fast API to a function returning a complex data structure. Can you give some hints?

Environment* env = Environment::GetCurrent(args);

// Get the double array pointer from the Float64Array argument.
Local<ArrayBuffer> ab = get_fields_array_buffer(args, 0, 2);
double* fields = static_cast<double*>(ab->Data());

#ifdef __linux__
clockid_t clockid;
pthread_getcpuclockid(pthread_self(), &clockid);

struct rusage usage;

if (getrusage(RUSAGE_THREAD, &usage) == -1) {
ShogunPanda marked this conversation as resolved.
Show resolved Hide resolved
return THROW_ERR_THREAD_CPU_USAGE_FAILED(env);
}

fields[0] = MICROS_PER_SEC * usage.ru_utime.tv_sec + usage.ru_utime.tv_usec;
fields[1] = MICROS_PER_SEC * usage.ru_stime.tv_sec + usage.ru_stime.tv_usec;
#elif __APPLE__
mach_port_t thread = mach_thread_self();
mach_msg_type_number_t count = THREAD_BASIC_INFO_COUNT;
thread_basic_info_data_t usage;
kern_return_t kr =
thread_info(thread, THREAD_BASIC_INFO, (thread_info_t)&usage, &count);

if (kr != KERN_SUCCESS) {
return THROW_ERR_THREAD_CPU_USAGE_FAILED(env);
}

fields[0] =
MICROS_PER_SEC * usage.user_time.seconds + usage.user_time.microseconds;
fields[1] = MICROS_PER_SEC * usage.system_time.seconds +
usage.system_time.microseconds;
#elif _WIN32
HANDLE thread_ = GetCurrentThread();
ShogunPanda marked this conversation as resolved.
Show resolved Hide resolved
FILETIME _creation_time, _exit_time, kernel_time, user_time;

if (!GetThreadTimes(
thread_, &_creation_time, &_exit_time, &kernel_time, &user_time)) {
return THROW_ERR_THREAD_CPU_USAGE_FAILED(env);
}

fields[0] = ((((uint64_t)user_time.dwHighDateTime << 32) |
ShogunPanda marked this conversation as resolved.
Show resolved Hide resolved
(uint64_t)user_time.dwLowDateTime) *
100) /
1000;
fields[1] = ((((uint64_t)system_ns.dwHighDateTime << 32) |
(uint64_t)system_ns.dwLowDateTime) *
100) /
1000;
#else
return THROW_ERR_THREAD_CPU_USAGE_UNSUPPORTED(env);
#endif
}

static void Cwd(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);
CHECK(env->has_run_bootstrapping_code());
Expand Down Expand Up @@ -650,6 +715,7 @@ static void CreatePerIsolateProperties(IsolateData* isolate_data,
SetMethod(isolate, target, "availableMemory", GetAvailableMemory);
SetMethod(isolate, target, "rss", Rss);
SetMethod(isolate, target, "cpuUsage", CPUUsage);
SetMethod(isolate, target, "threadCpuUsage", ThreadCPUUsage);
ShogunPanda marked this conversation as resolved.
Show resolved Hide resolved
SetMethod(isolate, target, "resourceUsage", ResourceUsage);

SetMethod(isolate, target, "_debugEnd", DebugEnd);
Expand Down Expand Up @@ -694,6 +760,7 @@ void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
registry->Register(GetAvailableMemory);
registry->Register(Rss);
registry->Register(CPUUsage);
registry->Register(ThreadCPUUsage);
registry->Register(ResourceUsage);

registry->Register(GetActiveRequests);
Expand Down
76 changes: 76 additions & 0 deletions test/parallel/test-process-threadCpuUsage-main-thread.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
'use strict';

require('../common');

const { ok, throws, notStrictEqual } = require('assert');

function validateResult(result) {
notStrictEqual(result, null);

ok(Number.isFinite(result.user));
ok(Number.isFinite(result.system));

ok(result.user >= 0);
ok(result.system >= 0);
}

// Test that process.threadCpuUsage() works on the main thread
{
const result = process.threadCpuUsage();

// Validate the result of calling with no previous value argument.
validateResult(process.threadCpuUsage());

// Validate the result of calling with a previous value argument.
validateResult(process.threadCpuUsage(result));

// Ensure the results are >= the previous.
let thisUsage;
let lastUsage = process.threadCpuUsage();
for (let i = 0; i < 10; i++) {
thisUsage = process.threadCpuUsage();
validateResult(thisUsage);
ok(thisUsage.user >= lastUsage.user);
ok(thisUsage.system >= lastUsage.system);
lastUsage = thisUsage;
}
}

// Test argument validaton
{
throws(
() => process.threadCpuUsage(123),
{
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError',
message: 'The "prevValue" argument must be of type object. Received type number (123)'
}
);

throws(
() => process.threadCpuUsage([]),
{
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError',
message: 'The "prevValue" argument must be of type object. Received an instance of Array'
}
);

throws(
() => process.threadCpuUsage({ user: -123 }),
{
code: 'ERR_INVALID_ARG_VALUE',
name: 'RangeError',
message: "The property 'prevValue.user' is invalid. Received -123"
}
);

throws(
() => process.threadCpuUsage({ user: 0, system: 'bar' }),
{
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError',
message: "The \"prevValue.system\" property must be of type number. Received type string ('bar')"
}
);
}
90 changes: 90 additions & 0 deletions test/parallel/test-process-threadCpuUsage-worker-threads.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,90 @@
'use strict';

const { mustCall, platformTimeout, hasCrypto, skip } = require('../common');
const { ok, deepStrictEqual } = require('assert');
const { randomBytes, createHash } = require('crypto');
const { once } = require('events');
const { Worker, isMainThread, parentPort, threadId } = require('worker_threads');

if (!hasCrypto) {
skip('missing crypto');
};

function performLoad() {
const buffer = randomBytes(1e8);
const index = threadId + 1;

// Do some work
return setInterval(() => {
createHash('sha256').update(buffer).end(buffer);
}, platformTimeout(index ** 2 * 100));
}

function getUsages() {
return { threadId, process: process.cpuUsage(), thread: process.threadCpuUsage() };
}

function validateResults(results) {
for (let i = 0; i < 4; i++) {
deepStrictEqual(results[i].threadId, i);
}

for (let i = 0; i < 3; i++) {
const processDifference = results[i].process.user / results[i + 1].process.user;
const threadDifference = results[i].thread.user / results[i + 1].thread.user;

//
// All process CPU usages should be the same. Technically they should have returned the same
// value but since we measure it at different times they vary a little bit.
// Let's allow a tolerance of 5%
//
ok(processDifference > 0.95);
ok(processDifference < 1.05);

//
// Each thread is configured so that the performLoad schedules a new hash with an interval two times bigger of the
// previous thread. In theory this should give each thread a load about half of the previous one.
// But since we can't really predict CPU scheduling, we just verify a minimum difference of 20% and a monotonic
// increasing sequence.
//
ok(threadDifference > 1.2);
}
}


// The main thread will spawn three more threads, then after a while it will ask all of them to
// report the thread CPU usage and exit.
if (isMainThread) {
const workers = [];
for (let i = 0; i < 3; i++) {
workers.push(new Worker(__filename));
}

setTimeout(mustCall(async () => {
clearInterval(interval);

const results = [getUsages()];

for (const worker of workers) {
const statusPromise = once(worker, 'message');
const exitPromise = once(worker, 'exit');

worker.postMessage('done');
const [status] = await statusPromise;
results.push(status);
await exitPromise;
}

validateResults(results);
}), platformTimeout(5000));

} else {
parentPort.on('message', () => {
clearInterval(interval);
parentPort.postMessage(getUsages());
process.exit(0);
});
}

// Perform load on each thread
const interval = performLoad();
Loading