Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add codeowners of security release document #56521

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

meta: add codeowners of security release document #56521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,9 @@
/src/permission/* @nodejs/security-wg
/test/parallel/test-permission-* @nodejs/security-wg

# Security Release
/doc/contributing/security-release-process.md @nodejs/security-release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the right group for codeowners. The people who follow this process are the security stewards, most of whom are not members of security-release (which is more or less releasers).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(There is a team for the security stewards, but only in the private org. -- I'm not sure if that's an oversight because the other security-* teams are replicated between the two orgs.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I change it to @nodejs/security? We don't have a security stewards group but we could create if needed.


# Dependency Update Tools

/.github/workflows/tools.yml @nodejs/security-wg
Expand Down
Loading