Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2854: Take into account ignore suffixes from the server confi… (Sourcery refactored) #4309

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Nov 9, 2023

Pull Request #4308 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the wip-NXDRIVE-2854-Take-into-account-ignore-suffixes-from-the-server-configuration branch, then run:

git fetch origin sourcery/wip-NXDRIVE-2854-Take-into-account-ignore-suffixes-from-the-server-configuration
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from swetayadav1 November 9, 2023 10:34
if value in ("unsync", "delete_server"):
if value in {"unsync", "delete_server"}:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function _validate_deletion_behavior refactored with the following changes:

return int(value)
return value
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function validate_sync_root_max_level_limits refactored with the following changes:

for feature in vars(Feature).keys():
for feature in vars(Feature):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 642-642 refactored with the following changes:

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sourcery AI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eaf804c) 47.68% compared to head (990d5b7) 47.65%.

Additional details and impacted files
@@                                                 Coverage Diff                                                  @@
##           wip-NXDRIVE-2854-Take-into-account-ignore-suffixes-from-the-server-configuration    #4309      +/-   ##
====================================================================================================================
- Coverage                                                                             47.68%   47.65%   -0.03%     
====================================================================================================================
  Files                                                                                    94       94              
  Lines                                                                                 15677    15677              
====================================================================================================================
- Hits                                                                                   7475     7471       -4     
- Misses                                                                                 8202     8206       +4     
Flag Coverage Δ
functional 36.72% <100.00%> (-0.03%) ⬇️
integration 2.06% <33.33%> (ø)
unit 37.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
nxdrive/options.py 99.51% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sourcery-ai sourcery-ai bot closed this Nov 22, 2023
@sourcery-ai sourcery-ai bot deleted the sourcery/wip-NXDRIVE-2854-Take-into-account-ignore-suffixes-from-the-server-configuration branch November 22, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant