-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NXDRIVE-2854: Take into account ignore suffixes from the server confi… (Sourcery refactored) #4309
Conversation
if value in ("unsync", "delete_server"): | ||
if value in {"unsync", "delete_server"}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function _validate_deletion_behavior
refactored with the following changes:
- Use set when checking membership of a collection of literals (
collection-into-set
)
return int(value) | ||
return value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function validate_sync_root_max_level_limits
refactored with the following changes:
- Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast
)
for feature in vars(Feature).keys(): | ||
for feature in vars(Feature): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 642-642
refactored with the following changes:
- Remove unnecessary call to keys() (
remove-dict-keys
)
Sourcery AI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## wip-NXDRIVE-2854-Take-into-account-ignore-suffixes-from-the-server-configuration #4309 +/- ##
====================================================================================================================
- Coverage 47.68% 47.65% -0.03%
====================================================================================================================
Files 94 94
Lines 15677 15677
====================================================================================================================
- Hits 7475 7471 -4
- Misses 8202 8206 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Pull Request #4308 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
wip-NXDRIVE-2854-Take-into-account-ignore-suffixes-from-the-server-configuration
branch, then run:Help us improve this pull request!