-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NXDRIVE-2854: Take into account ignore suffixes from the server confi… (Sourcery refactored) #4309
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -599,7 +599,7 @@ def validate_use_sentry(value: bool, /) -> bool: | |
|
||
|
||
def _validate_deletion_behavior(value: str, /) -> str: | ||
if value in ("unsync", "delete_server"): | ||
if value in {"unsync", "delete_server"}: | ||
return value | ||
raise ValueError(f"Unknown deletion behavior {value!r}") | ||
|
||
|
@@ -626,7 +626,7 @@ def validate_tmp_file_limit(value: Union[int, float], /) -> float: | |
|
||
def validate_sync_root_max_level_limits(value: int, /) -> int: | ||
if 0 <= value <= 4: | ||
return int(value) | ||
return value | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Function
|
||
raise ValueError("'sync_root_max_level' must be between 0 and 4 (inclusive).") | ||
|
||
|
||
|
@@ -639,7 +639,7 @@ def _callback_synchronization_enabled(new_value: bool) -> None: | |
|
||
|
||
# Handler callback for each feature | ||
for feature in vars(Feature).keys(): | ||
for feature in vars(Feature): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lines
|
||
Options.callbacks[f"feature_{feature}"] = CallableFeatureHandler(feature) | ||
|
||
Options.callbacks["deletion_behavior"] = lambda v: log.info( | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function
_validate_deletion_behavior
refactored with the following changes:collection-into-set
)