[linux] enabled global menubar on Ubuntu #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposed APIs for global menubar on Ubuntu. This patch also removed global menubar for DevTools window. fixed partially on nwjs/nw.js#2718
rogerwang
force-pushed
the
nw19
branch
5 times, most recently
from
8643404 to
481d448
Compare
rogerwang
force-pushed
the
nw19
branch
2 times, most recently
from
00b0e65 to
ba76bd3
Compare
rogerwang
force-pushed
the
nw19
branch
4 times, most recently
from
5e25421 to
287e391
Compare
GnorTech
pushed a commit
that referenced
this pull request
Jan 29, 2017
In future OS versions, we should fetch the multiprocess-enabled setting from WebViewDelegate instead of querying the setting directly. Add the skeleton code to get this from the delegate under a build version condition. BUG=684489 Review-Url: https://codereview.chromium.org/2645413002 Cr-Commit-Position: refs/heads/master@{#445705} (cherry picked from commit acc84fb) Review-Url: https://codereview.chromium.org/2649273004 . Cr-Commit-Position: refs/branch-heads/2987@{#56} Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang
pushed a commit
that referenced
this pull request
Mar 11, 2017
As shown in the referenced bug, testCloseAllTabs was failing because the stack view visibility check was checking for a nil stack view. This is likely occurring because the visibility check was occurring before the touch event that should show the tab switcher is handled. Adding this condition will wait for the touch event to be handled before checking for visibility. BUG=693517 Review-Url: https://codereview.chromium.org/2706403006 Cr-Commit-Position: refs/heads/master@{#455293} (cherry picked from commit 389418d) Review-Url: https://codereview.chromium.org/2734283002 . Cr-Commit-Position: refs/branch-heads/3029@{#56} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech
pushed a commit
that referenced
this pull request
Apr 26, 2017
Patch is designed as a quick and easy fix that should be easy to merge. A more comprehensive follow up will come later. BUG=711183 Review-Url: https://codereview.chromium.org/2812223008 Cr-Commit-Position: refs/heads/master@{#465355} (cherry picked from commit cabc715) Review-Url: https://codereview.chromium.org/2828053002 . Cr-Commit-Position: refs/branch-heads/3071@{#56} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech
pushed a commit
that referenced
this pull request
Aug 5, 2017
Fix the system beep that happen when closing a tab in some situations (see this repro: https://bugs.chromium.org/p/chromium/issues/detail?id=682299#c56) This is probably not the best way to fix this bug but it's probably a sufficient workaround until we find a better fix. TBR=sebmarchand@chromium.org (cherry picked from commit cf97ed5) Bug: 682299 Change-Id: I3a6c08cb01d3c2f6de1a8a2fee53a43eefde1e4d Reviewed-on: https://chromium-review.googlesource.com/581571 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Paul Meyer <paulmeyer@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489146} Reviewed-on: https://chromium-review.googlesource.com/586918 Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#56} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech
pushed a commit
that referenced
this pull request
Sep 14, 2017
This CL adds UMA for visiting pages within chrome://settings/. We previously had UMA for visiting top-level chrome://settings/, but it didn't record paths within settings or navigations within chrome://settings/. e.g. chrome://settings/appearance/ or chrome://settings/content/cookies/ TBR=dschuyler@chromium.org, thakis@chromium.org (cherry picked from commit be66a71) Bug: 760804 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9735e20e32bea060bdd8ef8b5910da7667a73653 Reviewed-on: https://chromium-review.googlesource.com/646911 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499367} Reviewed-on: https://chromium-review.googlesource.com/653479 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#56} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech
pushed a commit
that referenced
this pull request
Oct 27, 2017
This CL changes the relative position for tooltips vs the trigger for the tooltip so that the tooltip shows up reliably. Bug: 774046 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I78f8fd6b95992a2c4e3f1a1d7b1ff43a969a4654 Reviewed-on: https://chromium-review.googlesource.com/719581 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509188}(cherry picked from commit 5f88902) Reviewed-on: https://chromium-review.googlesource.com/726400 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#56} Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang
pushed a commit
that referenced
this pull request
Jan 29, 2018
This fix a potential bug that can happen, based on the crash report https://crbug.com/803244. It was not taken into account when landing https://crrev.com/c/867177. TBR=jinsukkim@chromium.org (cherry picked from commit 0c54236) Bug: 803244 Change-Id: I99c4d927cc69567efae619622ce8baf434cc332b Reviewed-on: https://chromium-review.googlesource.com/874976 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530419} Reviewed-on: https://chromium-review.googlesource.com/882921 Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#56} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech
pushed a commit
that referenced
this pull request
Mar 20, 2018
This cl converts the Keyboard Shortcut Viewer (KSV) switch to a base::Feature which is enabled by default. TBR=oshima@chromium.org Bug: 768932, 778874 Test: the feature works properly Change-Id: I38517d3084f2f493c822d3c435101525d2c98839 Reviewed-on: https://chromium-review.googlesource.com/946550 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540584}(cherry picked from commit 40de263) Reviewed-on: https://chromium-review.googlesource.com/952169 Reviewed-by: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#56} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang
pushed a commit
that referenced
this pull request
Apr 25, 2018
Mac's default "Edit -> Emoji & Symbols" menu item accelerator is specified as the accelerator for the (MacViews) context menu item. Bug: 827404 Change-Id: Ia030d6d0acebcb8481b39eea6c659f6855f6e5ab Reviewed-on: https://chromium-review.googlesource.com/1011240 Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550871}(cherry picked from commit 5cefa30) Reviewed-on: https://chromium-review.googlesource.com/1014507 Cr-Commit-Position: refs/branch-heads/3396@{#56} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang
pushed a commit
that referenced
this pull request
Jun 19, 2018
This CL adds metrics for download location change feature, including: 1. Type of the download location dialog. 2. Result of showing the location dialog. 3. The directory picked by the user. TBR=xingliu@chromium.org (cherry picked from commit ee50f11) Bug: 792775 Change-Id: I746edc3ca863ac9bacddb8cfdc5cabed66c3d8d1 Reviewed-on: https://chromium-review.googlesource.com/1071101 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#561754} Reviewed-on: https://chromium-review.googlesource.com/1080368 Reviewed-by: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#56} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech
pushed a commit
that referenced
this pull request
Aug 4, 2018
UIButton's don't handle dynamic types well. So we'll keep it fixed at a bold 17px. Screenshots: https://drive.google.com/file/d/1befS0btYrluxxdfjZ-RJJ4aUnluyylX8/view?usp=sharing https://drive.google.com/file/d/1tQSYQrDqmWuWhNVmJkYxjHy9Yp75OZ9L/view?usp=sharing Bug: 865008 Change-Id: Ic76e8264123b647cfe19e580e1abdd98b9e6a229 Reviewed-on: https://chromium-review.googlesource.com/1145227 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#576929}(cherry picked from commit 2a982a1) Reviewed-on: https://chromium-review.googlesource.com/1148614 Cr-Commit-Position: refs/branch-heads/3497@{#56} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang
pushed a commit
that referenced
this pull request
Sep 15, 2018
Bug: 879401 Test: eve does not have assistant button Change-Id: Ie65d700eb6c052d2089bef6ec2a209bdd12dbc9b Reviewed-on: https://chromium-review.googlesource.com/1198282 Reviewed-by: Weidong Guo <weidongg@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#587876}(cherry picked from commit bc895ea) Reviewed-on: https://chromium-review.googlesource.com/1207910 Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#56} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang
pushed a commit
that referenced
this pull request
Oct 31, 2018
This CL changes the storage string to [storage used by download] of [total disk size]. TBR=xingliu@chromium.org (cherry picked from commit ef9df5c) Bug: 892328 Change-Id: I6516c89e4f6bf71101c56b43171375a037cc36bf Reviewed-on: https://chromium-review.googlesource.com/c/1277917 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599703} Reviewed-on: https://chromium-review.googlesource.com/c/1284210 Reviewed-by: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#56} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang
pushed a commit
that referenced
this pull request
Dec 18, 2018
Bug: 910712 Change-Id: I70b768c1215ef0f540fbccbe98d0907881388782 Reviewed-on: https://chromium-review.googlesource.com/c/1357537 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613349}(cherry picked from commit ebd9b95) Reviewed-on: https://chromium-review.googlesource.com/c/1362479 Reviewed-by: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#56} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang
pushed a commit
that referenced
this pull request
Feb 10, 2019
The primary purpose of this CL is to fix a bug, when Download Manager UI persists after closing and reopening a tab. There is an alternative fix which is to dismiss Download Manager UI in DownloadManagerTabHelper::WebStateWasDestroyed, but calling WebState::WasHidden for closed WebState sounds like the right approach in general. TBR=eugenebut@chromium.org (cherry picked from commit 6ebb327) Bug: 919974 Change-Id: I204514995d616297b0745763dcd5acc21afef678 Reviewed-on: https://chromium-review.googlesource.com/c/1433497 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#626608} Reviewed-on: https://chromium-review.googlesource.com/c/1444140 Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#56} Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang
pushed a commit
that referenced
this pull request
Mar 24, 2019
TabFavicon is Tab's UserData which should not be accessed after Tab is destroyed or its WebContent is not ready yet. This CL adds the corresponding check to avoid NPE that occurs when working in accessibility mode, which attempts to access a Tab already destroyed after an animation effect or Tab is not loaded with a new WebContents object. Bug: 940332 Change-Id: If77c0eab251fb0bc728f046605a9f6930187557b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516116 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#639735}(cherry picked from commit 01084125cf95d52cf9b06fafcc2eac07098302de) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518841 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#56} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed APIs for global menubar on Ubuntu. This patch also removed
global menubar for DevTools window.
fixed partially on nwjs/nw.js#2718