Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More testing and cleanup of legacy components #1039

Merged
merged 27 commits into from
Jan 2, 2025
Merged

More testing and cleanup of legacy components #1039

merged 27 commits into from
Jan 2, 2025

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Dec 5, 2024

What's new

Addresses some points from #984

  • Lots more tests, but leaving out a large chunk of testing TaskForm as we will migrate to json-forms soon
  • Clean up legacy components, low-resolution custom logic

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…utext table

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 87.79343% with 26 lines in your changes missing coverage. Please review.

Project coverage is 70.92%. Comparing base (1a9d593) to head (e28af2a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...board-framework/src/components/tasks/task-form.tsx 43.33% 17 Missing ⚠️
...ework/src/components/tasks/types/compose-clean.tsx 66.66% 4 Missing ⚠️
...rd-framework/src/components/tasks/tasks-window.tsx 92.10% 3 Missing ⚠️
...rmf-dashboard-framework/src/components/map/map.tsx 83.33% 1 Missing ⚠️
...dashboard-framework/src/components/robots/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1039       +/-   ##
===========================================
+ Coverage   51.82%   70.92%   +19.10%     
===========================================
  Files         295      288        -7     
  Lines       15310    14608      -702     
  Branches      772     1136      +364     
===========================================
+ Hits         7934    10361     +2427     
+ Misses       7334     4223     -3111     
+ Partials       42       24       -18     
Flag Coverage Δ
rmf-dashboard-framework 68.56% <87.79%> (+23.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth marked this pull request as ready for review December 19, 2024 07:11
@aaronchongth aaronchongth merged commit c7ef8d6 into main Jan 2, 2025
2 checks passed
@aaronchongth aaronchongth deleted the cleanup branch January 2, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants