-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADIOS2: Optionally write attributes only from given ranks #1542
ADIOS2: Optionally write attributes only from given ranks #1542
Conversation
b33199c
to
0ec5af4
Compare
bd0e908
to
064cacd
Compare
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
@eschnett thinking about portable code that also supports HDF5, would this interrupt you if we enabled this by default (in a follow-up PR)? 😅 |
@ax3l I don't understand the ramifications. On the surface this all seems benign and beneficial. |
@eschnett The possible pitfall is that this would by default ignore any attribute that is not written on rank 0.
In consequence: Portable code using the openPMD-api should treat attribute writes as something collective. If attributes are written collectively, there's no harm in ADIOS2 to ignore any attribute write except for those on rank 0. This is why we're thinking about enabling this by default. If for some reason you have routines that create some data only on a few select ranks, this could lead to problems. |
@ax3l If we decide to activate this by default, we should maybe add some easy way to activate attribute writing from all ranks. Currently, |
Thanks for the explanation. I was not aware that openPMD treated attribute writes as global. This will be good to know. |
Performance optimization especially for large scale
Ref.
ornladios/ADIOS2#3846 (comment)
TODO: