Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MR API patch error fix #3411

Merged

Conversation

YuliaKrimerman
Copy link
Contributor

HOAIENG-14812

Description

A follow up fix for the saving wasn't working because of an API changed made. Added the needed value the API was needing.

How Has This Been Tested?

on MR UI- PLEASE use only modelregistry-sample-2 or a new model registry you create, as there is a bug on the API side that doesn't patch the old registries.

Test Impact

Test were written in the original feature PR

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now so we can verify the story, but we may need to make sure the MR team fixes their issue with existing registries not updating when the operator updates, or this patch won't work for existing users who update. Will follow up, we may want to revert this and #3369 before we release.

Copy link
Contributor

openshift-ci bot commented Oct 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.92%. Comparing base (21907eb) to head (850cfa5).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3411      +/-   ##
==========================================
- Coverage   85.92%   85.92%   -0.01%     
==========================================
  Files        1338     1338              
  Lines       30191    30193       +2     
  Branches     8296     8298       +2     
==========================================
+ Hits        25942    25943       +1     
- Misses       4249     4250       +1     
Files with missing lines Coverage Δ
...ns/ModelVersionDetails/ModelVersionDetailsView.tsx 95.23% <100.00%> (+0.23%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21907eb...850cfa5. Read the comment docs.

@openshift-merge-bot openshift-merge-bot bot merged commit 40fa17e into opendatahub-io:main Oct 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants