Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply formatMemory on Storage Size Units in Cluster Storage Table #3603

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Dec 20, 2024

https://issues.redhat.com/browse/RHOAIENG-16797

Description

Before
Screenshot 2024-12-20 at 10 59 49 AM

After
Screenshot 2024-12-20 at 10 59 59 AM

How Has This Been Tested?

  1. Go to Data Science Projects.
  2. Select a project -> Workbenches.
  3. Create workbench.
  4. Scroll down to "Cluster storage" table.
  5. Verify the correct units are applied.

Test Impact

Updated workbench.cy.ts.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from Gkrumbach07 and ppadti December 20, 2024 16:10
@jenny-s51 jenny-s51 changed the title RHOAIENG-16797: Apply formatMemory on Storage Size Units in Cluster Storage Table Apply formatMemory on Storage Size Units in Cluster Storage Table Dec 20, 2024
@christianvogt
Copy link
Contributor

@jenny-s51 there is a cypress test failure

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.15%. Comparing base (f9ac99e) to head (875d70d).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3603      +/-   ##
==========================================
+ Coverage   85.13%   85.15%   +0.01%     
==========================================
  Files        1395     1395              
  Lines       32034    32041       +7     
  Branches     8973     8979       +6     
==========================================
+ Hits        27273    27284      +11     
+ Misses       4761     4757       -4     
Files with missing lines Coverage Δ
...ts/screens/spawner/storage/ClusterStorageTable.tsx 59.37% <ø> (ø)

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9ac99e...875d70d. Read the comment docs.

Copy link
Contributor Author

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @christianvogt - updated the test.

@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ca83e34 into opendatahub-io:main Dec 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants