-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply formatMemory on Storage Size Units in Cluster Storage Table #3603
Apply formatMemory on Storage Size Units in Cluster Storage Table #3603
Conversation
@jenny-s51 there is a cypress test failure |
fix import order fix test
d50093c
to
875d70d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3603 +/- ##
==========================================
+ Coverage 85.13% 85.15% +0.01%
==========================================
Files 1395 1395
Lines 32034 32041 +7
Branches 8973 8979 +6
==========================================
+ Hits 27273 27284 +11
+ Misses 4761 4757 -4
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @christianvogt - updated the test.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-16797
Description
Before
After
How Has This Been Tested?
Test Impact
Updated
workbench.cy.ts
.Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main