Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply formatMemory on Storage Size Units in Cluster Storage Table #3603

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Apply formatMemory on Storage Size Units in Cluster Storage Table #3603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/__tests__/cypress/cypress/tests/mocked/projects/workbench.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ describe('Workbench page', () => {
// cluster storage
const storageTableRow = createSpawnerPage.getStorageTable().getRowById(0);
storageTableRow.findNameValue().should('have.text', 'test-project-storage');
storageTableRow.findStorageSizeValue().should('have.text', 'Max 20Gi');
storageTableRow.findStorageSizeValue().should('have.text', 'Max 20GiB');
storageTableRow.findMountPathValue().should('have.text', '/opt/app-root/src/');

//add data connection
Expand Down
3 changes: 2 additions & 1 deletion frontend/src/pages/projects/screens/spawner/storage/ClusterStorageTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { InfoCircleIcon } from '@patternfly/react-icons';

import { Table } from '~/components/table';
import { StorageData, StorageType } from '~/pages/projects/types';
import { formatMemory } from '~/utilities/valueUnits';
import { clusterStorageTableColumns } from './constants';
import { ClusterStorageDetachModal } from './ClusterStorageDetachModal';
import WorkbenchStorageModal from './WorkbenchStorageModal';
Expand Down Expand Up @@ -116,7 +117,7 @@ export const ClusterStorageTable: React.FC<ClusterStorageTableProps> = ({
)}
</Flex>
</Td>
<Td dataLabel="Storage size">Max {row.size}</Td>
<Td dataLabel="Storage size">Max {formatMemory(row.size)}</Td>
<Td dataLabel="Mount path">{row.mountPath}</Td>
<Td isActionCell>
<ActionsColumn
Expand Down
Loading