Give default title and action label to the application enable modal #3648
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.redhat.com/browse/RHOAIENG-425
Description
In
OdhApplication
CRD, the fieldspec.enable
may not containtitle
andactionLabel
fields. Give them default value to show the enable modal correctly. Default fallback title isspec.displayName
and default fallback actionLabel isEnable
How Has This Been Tested?
Import the following YAML to your cluster using OpenShift console
opendatahub
namespace (or the namespace where you deployed the ODH dashboard)Validate if the title is
Enable {displayName}
and the button is showingEnable
as expected.Test Impact
N/A, we don't have a test for the enable modal because it's an old component, not sure if it worth the effort to write tests for that.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main