Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give default title and action label to the application enable modal #3648

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Give default title and action label to the application enable modal #3648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/src/pages/exploreApplication/EnableModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,17 +99,17 @@
className="odh-enable-modal"
data-id="enable-modal"
variant={ModalVariant.small}
title={enable.title}
title={enable.title || `Enable ${selectedApp.spec.displayName}`}

Check warning on line 102 in frontend/src/pages/exploreApplication/EnableModal.tsx

View check run for this annotation

Codecov / codecov/patch

frontend/src/pages/exploreApplication/EnableModal.tsx#L102 

Added line #L102 was not covered by tests
isOpen
onClose={handleClose}
actions={[
<Button
key="confirm"
variant="primary"
onClick={onDoEnableApp}
isDisabled={validationInProgress || isEnableValuesHasEmptyValue}
isDisabled={validationInProgress || (enable.variables && isEnableValuesHasEmptyValue)}

Check warning on line 110 in frontend/src/pages/exploreApplication/EnableModal.tsx

View check run for this annotation

Codecov / codecov/patch

frontend/src/pages/exploreApplication/EnableModal.tsx#L110 

Added line #L110 was not covered by tests
>
{enable.actionLabel}
{enable.actionLabel || 'Enable'}

Check warning on line 112 in frontend/src/pages/exploreApplication/EnableModal.tsx

View check run for this annotation

Codecov / codecov/patch

frontend/src/pages/exploreApplication/EnableModal.tsx#L112 

Added line #L112 was not covered by tests
</Button>,
<Button key="cancel" variant="link" onClick={handleClose}>
{validationInProgress ? 'Close' : 'Cancel'}
Expand Down
Loading