Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Show the GPU requests and limits in workbench table #3654

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Show the GPU requests and limits in workbench table

f8d97c8
Select commit
Loading
Failed to load commit list.
Open

[WIP] Show the GPU requests and limits in workbench table #3654

Show the GPU requests and limits in workbench table
f8d97c8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 17, 2025 in 1s

84.25% (-0.01%) compared to 7ffc255

View this Pull Request on Codecov

84.25% (-0.01%) compared to 7ffc255

Details

Codecov Report

Attention: Patch coverage is 85.71429% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.25%. Comparing base (7ffc255) to head (f8d97c8).

Files with missing lines Patch % Lines
...s/screens/detail/notebooks/NotebookSizeDetails.tsx 57.14% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3654      +/-   ##
==========================================
- Coverage   84.26%   84.25%   -0.01%     
==========================================
  Files        1432     1434       +2     
  Lines       33489    33514      +25     
  Branches     9284     9297      +13     
==========================================
+ Hits        28218    28237      +19     
- Misses       5271     5277       +6     
Files with missing lines Coverage Δ
...r/screens/server/AcceleratorProfileSelectField.tsx 66.66% <100.00%> (-0.38%) ⬇️
...ller/screens/server/useAcceleratorCountWarning.tsx 100.00% <100.00%> (ø)
...ects/screens/detail/notebooks/NotebookTableRow.tsx 88.05% <100.00%> (+0.18%) ⬆️
...c/pages/projects/screens/detail/notebooks/utils.ts 100.00% <100.00%> (ø)
...s/screens/detail/notebooks/NotebookSizeDetails.tsx 68.42% <57.14%> (-31.58%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ffc255...f8d97c8. Read the comment docs.