Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Count implicit tags #133

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Conversation

bradenmacdonald
Copy link
Contributor

This updates our "get tag counts" API so that the tag counts can include the implicit tags.

Currently, we have an inconsistency in how the counts are displayed in the platform:
Screenshot 2023-12-14 at 10 19 56 AM
Screenshot 2023-12-14 at 10 21 07 AM

This API change will allow us to make the counts in both places include the implicit tags (use the higher number consistently).

Private ref: FAL-3573

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 14, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link
Member

@yusuf-musleh yusuf-musleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, works well.

  • I tested this: I made sure the tag counts (including implicit) were correct by adding/removing tags
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@bradenmacdonald
Copy link
Contributor Author

@ormsbee would you mind reviewing this PR?

Copy link
Contributor

@ormsbee ormsbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of those things where I think we should watch the performance numbers closely. And now that we're completely on MySQL 8.0, I suspect we could do more of this in the database with CTE. But that can be a bridge we cross if and when we need to.

@ChrisChV
Copy link
Contributor

@ormsbee Thanks for the review! Could you merge this PR? @bradenmacdonald is on holidays 🙂

@ormsbee ormsbee merged commit 0f90a7f into openedx:main Dec 21, 2023
7 checks passed
@openedx-webhooks
Copy link

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@bradenmacdonald bradenmacdonald deleted the braden/count-implicit branch January 4, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants