-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[network] Add parameter for limiting network interfaces to fix performance issues #16145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is good, just an update of documentation is missing
bundles/org.openhab.binding.network/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
…mance issues * Add configuration parameter for limiting network interfaces * Use last known reachable interface Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Wouter Born <github@maindrain.net>
c47c46f
to
53f1b74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
…mance issues (openhab#16145) * [network] Add parameter for limiting network interfaces to fix performance issues * Use last known reachable interface --------- Signed-off-by: Wouter Born <github@maindrain.net>
@wborn Is this something that should be backported to 4.1.x? |
It would be nice to get this solved. Though openhab/openhab-webui#2246 is also needed for proper UI support. |
@florian-h05 Do you think openhab/openhab-webui#2246 can be merged and also backported tonight? |
I planned to do that before leaving home, but didn’t have the time. |
Great, thank you. It is a minimal code change - if you say, it looks alright, I can also merge and cherry-pick, if you like. |
Cherry-picked to |
…mance issues (#16145) * [network] Add parameter for limiting network interfaces to fix performance issues * Use last known reachable interface --------- Signed-off-by: Wouter Born <github@maindrain.net>
This allows for selecting multiple network interface names in configuration parameters. Related to: * openhab/openhab-core#3981 * openhab/openhab-addons#16145 Signed-off-by: Wouter Born <github@maindrain.net>
This allows for selecting multiple network interface names in configuration parameters. Related to: * openhab/openhab-core#3981 * openhab/openhab-addons#16145 Signed-off-by: Wouter Born <github@maindrain.net>
…mance issues (openhab#16145) * [network] Add parameter for limiting network interfaces to fix performance issues * Use last known reachable interface --------- Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
…mance issues (openhab#16145) * [network] Add parameter for limiting network interfaces to fix performance issues * Use last known reachable interface --------- Signed-off-by: Wouter Born <github@maindrain.net>
Fixes #15437
Depends on openhab/openhab-core#3981