Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[network] Add parameter for limiting network interfaces to fix performance issues #16145

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

wborn
Copy link
Member

@wborn wborn commented Dec 29, 2023

  • Add configuration parameter for limiting network interfaces
  • Use last known reachable interface

Fixes #15437

Depends on openhab/openhab-core#3981

@wborn wborn added enhancement An enhancement or new feature for an existing add-on awaiting other PR Depends on another PR labels Dec 29, 2023
@wborn wborn removed the awaiting other PR Depends on another PR label Jan 1, 2024
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good, just an update of documentation is missing

wborn added 2 commits January 3, 2024 17:18
…mance issues

* Add configuration parameter for limiting network interfaces
* Use last known reachable interface

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn force-pushed the network-performance branch from c47c46f to 53f1b74 Compare January 3, 2024 16:19
@wborn wborn requested a review from lolodomo January 3, 2024 16:21
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 18da507 into openhab:main Jan 3, 2024
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Jan 3, 2024
@wborn wborn deleted the network-performance branch January 3, 2024 18:30
Cybso pushed a commit to Cybso/openhab-addons that referenced this pull request Jan 5, 2024
…mance issues (openhab#16145)

* [network] Add parameter for limiting network interfaces to fix performance issues
* Use last known reachable interface

---------

Signed-off-by: Wouter Born <github@maindrain.net>
@kaikreuzer
Copy link
Member

@wborn Is this something that should be backported to 4.1.x?

@wborn
Copy link
Member Author

wborn commented Jan 5, 2024

It would be nice to get this solved. Though openhab/openhab-webui#2246 is also needed for proper UI support.

@kaikreuzer
Copy link
Member

@florian-h05 Do you think openhab/openhab-webui#2246 can be merged and also backported tonight?

@florian-h05
Copy link
Contributor

I planned to do that before leaving home, but didn’t have the time.
I will be late at home tonight, but I can try to do that ASAP after getting back home.

@kaikreuzer
Copy link
Member

Great, thank you. It is a minimal code change - if you say, it looks alright, I can also merge and cherry-pick, if you like.

@kaikreuzer
Copy link
Member

Cherry-picked to 4.1.x.

@kaikreuzer kaikreuzer added the patch A PR that has been cherry-picked to a patch release branch label Jan 5, 2024
kaikreuzer pushed a commit that referenced this pull request Jan 5, 2024
…mance issues (#16145)

* [network] Add parameter for limiting network interfaces to fix performance issues
* Use last known reachable interface

---------

Signed-off-by: Wouter Born <github@maindrain.net>
kaikreuzer pushed a commit to openhab/openhab-webui that referenced this pull request Jan 6, 2024
This allows for selecting multiple network interface names in
configuration parameters.

Related to:

* openhab/openhab-core#3981
* openhab/openhab-addons#16145

Signed-off-by: Wouter Born <github@maindrain.net>
kaikreuzer pushed a commit to openhab/openhab-webui that referenced this pull request Jan 6, 2024
This allows for selecting multiple network interface names in
configuration parameters.

Related to:

* openhab/openhab-core#3981
* openhab/openhab-addons#16145

Signed-off-by: Wouter Born <github@maindrain.net>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
…mance issues (openhab#16145)

* [network] Add parameter for limiting network interfaces to fix performance issues
* Use last known reachable interface

---------

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
…mance issues (openhab#16145)

* [network] Add parameter for limiting network interfaces to fix performance issues
* Use last known reachable interface

---------

Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[network] Pingdevice on Docker-Install results in massive threads
4 participants