Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon suggestions #2150

Merged
merged 4 commits into from
Nov 25, 2023
Merged

Addon suggestions #2150

merged 4 commits into from
Nov 25, 2023

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Oct 25, 2023

Depends on openhab/openhab-core#3806.

Work is underway in the core and addon repositories to automatically generate addon suggestions by scanning the network for mDNS and uPnP devices and suggesting relevant addons based in criteria in the addon.xml resource file.

In this PR, the UI is enhanced in 2 places:

  1. Have the setup wizard propose these addon suggestions (as a complement to the hardcoded recommended addons).
  2. List the addon suggestions on top in the addon store page.

@andrewfg: FYI

@mherwege mherwege requested a review from a team as a code owner October 25, 2023 16:34
@mherwege mherwege marked this pull request as draft October 25, 2023 16:34
@relativeci
Copy link

relativeci bot commented Oct 25, 2023

Job #1232: Bundle Size — 15.75MiB (-0.09%).

7c8c37d(current) vs b7270d2 main#1158(baseline)

Important

Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1232
     Baseline
Job #1158
Regression  Initial JS 1.85MiB(+10.96%) 1.67MiB
Regression  Initial CSS 609.06KiB(+0.03%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 2987(+75.71%) 1700
Regression  Duplicate Modules 173(+92.22%) 90
Improvement  Duplicate Code 1.61%(-17.44%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 1 regression Improvement 2 improvements
                 Current
Job #1232
     Baseline
Job #1158
Improvement  JS 9.24MiB (-0.16%) 9.25MiB
Improvement  Other 4.73MiB (~-0.01%) 4.73MiB
Regression  CSS 860.29KiB (+0.09%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1232 reportView mherwege:suggestions branch activity

@andrewfg
Copy link

@mherwege this is great :) but since I don't know vue I can't add any material feedback :(

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI awaiting other PR Depends on another PR labels Oct 26, 2023
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Copy link

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my live system test - LGTM

@mherwege mherwege marked this pull request as ready for review November 24, 2023 19:15
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, thanks a lot!

@ghys ghys merged commit 42193d1 into openhab:main Nov 25, 2023
5 checks passed
@lolodomo
Copy link
Contributor

This was merged probably too early, the stuff in core and addons is not yet merged.
I hope this will not break the snapshots of tomorrow...

@mherwege
Copy link
Contributor Author

Pre-mature indeed. I don't think this can brake builds, but it will try to call a REST endpoint that doesn't exist yet in the UI. This will likely give errors in the UI log when opening the addon store. I don't expect other consequences (but did not test).

@ghys
Copy link
Member

ghys commented Nov 28, 2023

Apologies as I was (wrongly) under the impression the backend work was already approved... Should have checked better indeed. If needed we can revert the merge.

@lolodomo
Copy link
Contributor

@mherwege @andrewfg : maybe you could enhance slightly the following sections in the documentation ?
https://next.openhab.org/docs/tutorial/first_steps.html#install-add-ons
https://next.openhab.org/docs/configuration/addons.html#through-ui

@andrewfg
Copy link

@lolodomo done.

@mvalla
Copy link

mvalla commented Dec 24, 2023

@ghys @andrewfg can you point out which configuration is needed to test this in Eclipse dev environment?

@florian-h05 florian-h05 added this to the 4.1 milestone Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting other PR Depends on another PR enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants