-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon suggestions #2150
Addon suggestions #2150
Conversation
Job #1232: Bundle Size — 15.75MiB (-0.09%).Important Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages Warning Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages Bundle metrics
Bundle size by type
View job #1232 report View mherwege:suggestions branch activity |
@mherwege this is great :) but since I don't know vue I can't add any material feedback :( |
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on my live system test - LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition, thanks a lot!
This was merged probably too early, the stuff in core and addons is not yet merged. |
Pre-mature indeed. I don't think this can brake builds, but it will try to call a REST endpoint that doesn't exist yet in the UI. This will likely give errors in the UI log when opening the addon store. I don't expect other consequences (but did not test). |
Apologies as I was (wrongly) under the impression the backend work was already approved... Should have checked better indeed. If needed we can revert the merge. |
@mherwege @andrewfg : maybe you could enhance slightly the following sections in the documentation ? |
@lolodomo done. |
Depends on openhab/openhab-core#3806.
Work is underway in the core and addon repositories to automatically generate addon suggestions by scanning the network for mDNS and uPnP devices and suggesting relevant addons based in criteria in the addon.xml resource file.
In this PR, the UI is enhanced in 2 places:
@andrewfg: FYI