Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtt_ros2_topics: update RTT plugin name to "rostopic" to match "rosnode" and "rosparam" #22

Merged
merged 1 commit into from
Jul 27, 2020
Merged

rtt_ros2_topics: update RTT plugin name to "rostopic" to match "rosnode" and "rosparam" #22

merged 1 commit into from
Jul 27, 2020

Conversation

meyerj
Copy link
Member

@meyerj meyerj commented Jul 27, 2020

This PR concludes on #18 (Reconsider service names) (closes #18):

  • Package rtt_ros2_topics provides the service plugin "rostopic" now. At the moment the rostopic service cannot be loaded into a component. It only provides additional operations in the global service ros, which is why the string returned by getRTTPluginName() does not really matter. That might change in the future for addressing ROS topic transport improvements #16.

  • The service and plugin name provided by package rtt_ros2_params was changed to "rosparam" in b62ddea after a PR review of Add support for ROS2 parameters #7.

  • The service and plugin name provided by package rtt_ros2_node was already changed to "rosnode" in be27f6e and f6e9fe5 (Add support for ROS2 parameters #7).

@meyerj meyerj merged commit 906f831 into master Jul 27, 2020
@meyerj meyerj deleted the fix/change-rostopic-service-name branch July 27, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reconsider service names
1 participant
@meyerj