-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daylight Saving Time (DST) support #59 #62
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnd-au
commented
Oct 14, 2024
This was referenced Oct 17, 2024
jnd-au
force-pushed
the
62-dst-support
branch
from
October 25, 2024 04:15
2c99c2a
to
1aaf8b5
Compare
Thank you! 🙌🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds DST support and Unit Tests to contribute significantly toward a
tz
v1.0.0 release. It fixes pre-existing issues up to v0.7.0 (@oz) plus it fixes new unreleased regressions in HEAD (@wyne). Until now, tz has never properly supported DST transitions.This PR includes the following fixes:
-list
search syntax (fix d6c5408)Due to the extensive refactoring of core tz logic, this PR is quite ‘big’ so I’ve sub-divided it into small commits that are more easily reviewable. I’ve added baseline unit test data from v0.7.0, then incrementally updated it to show the impact and necessity of each change.
This PR includes the following new features to make DST clearer:
z
key)f
key)j
/k
keys)-
/+
keys)This PR depends on first merging PRs #54 and #61 (commits on 9 and 13 October), as they contain pre-requisite fixes as a basis for the functionality and unit-test data/expectations in this PR. Hence I’ve raised this as a Draft for the time being, although it’s ready for review (commits starting 14 October).