-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hal/ia32: Implement HP timer #476
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
astalke
force-pushed
the
astalke/RTOS-530
branch
from
November 14, 2023 13:49
9600996
to
4c25065
Compare
agkaminski
reviewed
Nov 14, 2023
astalke
force-pushed
the
astalke/RTOS-530
branch
from
November 14, 2023 14:50
4c25065
to
13e5a2a
Compare
agkaminski
reviewed
Nov 14, 2023
astalke
force-pushed
the
astalke/RTOS-530
branch
3 times, most recently
from
November 14, 2023 15:25
2005a01
to
2ef32db
Compare
agkaminski
previously approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Reason: The old name `when` is misleadig, since it is time to wait and not a fixed moment in time. Changed it to `waitUs`. JIRA: RTOS-530
- Move code reading and writing to Local APIC to its own functions. - Add detection of Local APIC Timer's frequency. - Make Local APIC timer the default timer for scheduling JIRA: RTOS-530
JIRA: RTOS-530
astalke
force-pushed
the
astalke/RTOS-530
branch
from
November 15, 2023 14:37
2ef32db
to
1e84866
Compare
agkaminski
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for 2 timers that may be available in ia32: Local APIC Timer and High Precision Event Timers (HPET). If they are available, they will be used instead of old Programmable Interval Timer (PIT).
Motivation and Context
This change makes it possible to sleep times shorter than 10ms.
Types of changes
How Has This Been Tested?
Checklist:
Special treatment