Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gr712rc port #300

Merged
merged 3 commits into from
Nov 15, 2023
Merged

gr712rc port #300

merged 3 commits into from
Nov 15, 2023

Conversation

lukileczo
Copy link
Member

@lukileczo lukileczo commented Oct 26, 2023 •
edited
Loading

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

@lukileczo lukileczo force-pushed the lukileczo/gr712rc branch 2 times, most recently from a5c579c to 7a1ccdb Compare October 26, 2023 13:39
@lukileczo lukileczo requested a review from agkaminski October 27, 2023 09:19
@lukileczo lukileczo marked this pull request as ready for review October 27, 2023 09:19
@lukileczo lukileczo force-pushed the lukileczo/gr712rc branch 3 times, most recently from 6e41f93 to 9e431d7 Compare October 27, 2023 12:01
agkaminski
agkaminski reviewed Nov 2, 2023
View reviewed changes
devices/flash-dummy/flashdrv.c Outdated Show resolved Hide resolved
devices/flash-dummy/flashdrv.c Outdated Show resolved Hide resolved
devices/flash-dummy/flashdrv.c Outdated Show resolved Hide resolved
hal/sparcv8leon3/gaisler/gr712rc/_init.S Outdated Show resolved Hide resolved
hal/sparcv8leon3/gaisler/gr712rc/config.h Outdated Show resolved Hide resolved
hal/sparcv8leon3/gaisler/gr716/peripherals.h Outdated Show resolved Hide resolved
hal/sparcv8leon3/gaisler/gr716/peripherals.h Outdated Show resolved Hide resolved
hal/sparcv8leon3/interrupts.c Outdated Show resolved Hide resolved
hal/sparcv8leon3/gaisler/grlib-tn-0018.h Outdated Show resolved Hide resolved
hal/sparcv8leon3/gaisler/grlib-tn-0018.h Outdated Show resolved Hide resolved
@lukileczo
phfs: increase alias size
60bc43b 
Needed for the GR712RC target.

JIRA: RTOS-616
@lukileczo
devices/ram-stm32: move to ram-storage
9a28ea4 
JIRA: RTOS-616
agkaminski
agkaminski previously approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023 •
edited
Loading

Unit Test Results

5 957 tests  +8   5 316 ✔️ +20   30m 4s ⏱️ - 2m 48s
   333 suites +8      641 💤  - 12 
       1 files   ±0          0 ❌ ±  0 

Results for commit 08296d8. ± Comparison against base commit f348b46.

♻️ This comment has been updated with latest results.

@lukileczo lukileczo requested a review from agkaminski November 8, 2023 13:47
agkaminski
agkaminski previously approved these changes Nov 10, 2023
View reviewed changes
@lukileczo lukileczo requested a review from agkaminski November 10, 2023 09:47
@lukileczo lukileczo force-pushed the lukileczo/gr712rc branch 3 times, most recently from f47e108 to ac3c4a3 Compare November 14, 2023 15:41
@lukileczo
add gr712rc target
08296d8 
refactor gaisler cpu support to be more generic

JIRA: RTOS-616
agkaminski
agkaminski approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukileczo lukileczo merged commit 1a35a3e into master Nov 15, 2023
30 checks passed
@lukileczo lukileczo deleted the lukileczo/gr712rc branch November 15, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agkaminski agkaminski agkaminski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukileczo @agkaminski