-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reporting and plots of renovation and construction flows #10
Conversation
…n and renovation flows
#### by Space heating (initial state) | ||
```{r Renovation-Residential-(heatingBefore)} | ||
showAreaAndBarPlots(data, vars = heatingResBefore, tot = totBefore, orderVars = "user", scales = "fixed") | ||
walk(heatingResBefore, showLinePlots, data = data) | ||
``` | ||
|
||
#### by Space heating (final state) | ||
```{r Renovation-Residential-(heatingAfter)} | ||
showAreaAndBarPlots(data, vars = heatingResAfter, tot = totAfter, orderVars = "user", scales = "fixed") | ||
``` | ||
|
||
#### by Space heating (final state, with zero renovation) | ||
```{r Renovation-Residential-(heatingAfter)} | ||
showAreaAndBarPlots(data, vars = heatingResAfterZero, tot = totAfterZero, orderVars = "user", scales = "fixed") | ||
walk(heatingResAfterZero, showLinePlots, data = data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the current variable naming means that the total is not shown in the plot, as the variables defined above actually do not exist. The total was still named in this way to preserve the coloring from mip.
Eventually this will require changes in mip to solve the issue:
- either add the variable names of the form "Initial|{hs}" to the mip plotstyle.csv
- or modify mip such that additional tags can be cut from the variable name - or such that the shared part of the variable name is removed (This can potentially change the behavior of mip for many other users!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found an easy (albeit not perfect) fix for this: If tot
is not specified in the call to showAreaAndBarPlots
, then the variable names are shortened by removing their common part, while said common part is considered to be the variable name of the total. However, the values of the total are computed simply as the sum of the plotted variables. So as a result, the area plots display the total and are colored correctly, but the total is not given by the variable Renovation|Residential
. but computed as the sum of e.g. Renovation|Residential|Initial|{hs}
To obtain a solution where the variable naming is provided by removing the common part, but the total is given by the respective variable, we'd need a change in mip
. The core problem here is that our variable name contains a tag (Initial
or Final
) that is meaningless without the tag following it (i.e. the specification of the heating system).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then let's go without the specific tot
and let's see if RSE can look into a mip change.
d9bcf71
to
df5dd50
Compare
Still missing in |
df5dd50
to
77a15e5
Compare
…, report and plot identical replacement vs. true renovations
I now adapted the bsr / hsr sets to aggregate over in renovation plots and now identical replacements and changes of the heating system are reported. An example pdf of the results can be found here: |
I included the requested and suggested changes, but I struggled a bit to come up with a meaningful variable naming. The logic I followed was to be concise but also as short as possible. For instance, we then have a variable |
I'd suggest to leave it as you suggested for now. In future, we could think about |
Implement reporting renovation flow to mif, add plots for construction and renovation flows.
Addresses issue #9 .