Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reporting and plots of renovation and construction flows #10
Reporting and plots of renovation and construction flows #10
Changes from 2 commits
e3dc985
77a15e5
76ab382
9b06ef7
6cf2785
fe129f7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the current variable naming means that the total is not shown in the plot, as the variables defined above actually do not exist. The total was still named in this way to preserve the coloring from mip.
Eventually this will require changes in mip to solve the issue:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found an easy (albeit not perfect) fix for this: If
tot
is not specified in the call toshowAreaAndBarPlots
, then the variable names are shortened by removing their common part, while said common part is considered to be the variable name of the total. However, the values of the total are computed simply as the sum of the plotted variables. So as a result, the area plots display the total and are colored correctly, but the total is not given by the variableRenovation|Residential
. but computed as the sum of e.g.Renovation|Residential|Initial|{hs}
To obtain a solution where the variable naming is provided by removing the common part, but the total is given by the respective variable, we'd need a change in
mip
. The core problem here is that our variable name contains a tag (Initial
orFinal
) that is meaningless without the tag following it (i.e. the specification of the heating system).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then let's go without the specific
tot
and let's see if RSE can look into a mip change.