Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added informative error message to if_else2() if no matches are found #25

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Added informative error message to if_else2() if no matches are found #25

merged 2 commits into from
Oct 31, 2024

Conversation

dunkenwg
Copy link
Contributor

@dunkenwg dunkenwg commented Oct 1, 2024

Also created a test to make sure if_else2() errors appropriately

joethorley
joethorley approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@joethorley joethorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

sarahLy9
sarahLy9 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@sarahLy9 sarahLy9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

aylapear
aylapear approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@aylapear aylapear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aylapear aylapear self-assigned this Oct 31, 2024
@aylapear aylapear merged commit 4973e9e into main Oct 31, 2024
11 checks passed
@aylapear aylapear deleted the ifelse2 branch October 31, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahLy9 sarahLy9 sarahLy9 approved these changes

@aylapear aylapear aylapear approved these changes

@joethorley joethorley joethorley approved these changes

Assignees

@aylapear aylapear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dunkenwg @joethorley @aylapear @sarahLy9