Add dynamic BurnParameters for Kusama Treasury
#511
+220
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v can decide on Burn parameters for Kusama Treasury.
pandres95
force-pushed
the
kusama-treasury-burn-parameters
branch
from
bc40137 to
db30521
Compare
acatangiu
reviewed
Jan 13, 2025
…eparate values, to be more ergonomic with `set_parameters` usage. Note: while `BurnDestinationAccount` is not as ergonomic since it comprises of an `Option<AccountId>` value, it's more ergonomic than comparing against an arbitrary `AccountId::from([0u8; 32])`. Note 2: The `BurnDestinationAccount` wrapper is unfortunately necessary, as explicitly stating `AccountId` failed. Need to report an issue on PSDK about this.
pandres95
force-pushed
the
kusama-treasury-burn-parameters
branch
from
0f10245 to
d24ea09
Compare
|
@acatangiu tests are ready |
acatangiu
approved these changes
Jan 14, 2025
relay/kusama/src/lib.rs
Outdated
Comment on lines
874
to
876
| let account = account.0.expect("given `account.0.is_some`; qed"); | ||
| // Must resolve into existing but better to be safe. | ||
| Balances::resolve_creating(&account, amount); |
There was a problem hiding this comment.
you can refactor to avoid the expect:
Suggested change
| let account = account.0.expect("given `account.0.is_some`; qed"); | |
| // Must resolve into existing but better to be safe. | |
| Balances::resolve_creating(&account, amount); | |
| if let Some(account) = account.0.as_ref() { | |
| // Must resolve into existing but better to be safe. | |
| Balances::resolve_creating(account, amount); | |
| } |
no need for else branch since you know it will always be Some
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request resolves the signal raised by the Kusama Ref. #437, setting both
BurnandBurnDestinationparameters in Kusama'spallet-treasuryas a structure (both of them need to be set to prevent some unwanted behaviour) that can be parametrized via OpenGov.Default (when set to
None) configuration behaves like what's already out there: 0%, no account.