-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
force unstake the last remaining corrupt ledger #538
base: main
Are you sure you want to change the base?
Conversation
This could be just its own referendum? |
yeah it could, but since it would require Root, and we have previously done other fixes related to this bug as runtime upgrade, I opted for this. We can still do Root, but it will certainly be longer, and a more cumbersome process. |
This could also be done via the whitelisted track? I mean this is just fixing up stuff, nothing controversial. |
Yeah since it is a technical bug, fellowship can be asked to whitelist. I think there is an easier path if we merge this as-is, since we are close to publishing 1.4 anyways, but if you think otherwise, we can also pursue it via the fellowship. |
impl OnRuntimeUpgrade for Migrate { | ||
fn on_runtime_upgrade() -> frame_election_provider_support::Weight { | ||
// ensure this only runs once, in the 1.4.0 release | ||
if VERSION.spec_version == 1_400_000 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if VERSION.spec_version == 1_400_000 { | |
if System::last_runtime_upgrade_spec_version() < 1_400_000 { |
do we do CHANGELOG for this? |
One last staking ledger that due to the bug found last year is in an inconsistent state.
The Support team is in touch with the owner, and force_staking them is the preferred way.
Note that this is only an action that we are doing because the root cause of the inconsistent stake was buggy code in the polkadot runtime, not any user interaction.
See: https://forum.polkadot.network/t/recover-corrupted-staking-ledgers-in-polkadot-and-kusama/9796