Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add fix for multibidspec flaky tests #2906

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

marki1an
Copy link
Collaborator

@marki1an marki1an commented Jan 16, 2024

This PR aim to resolve this one flaky test

Error:  Tests run: 10, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.455 s <<< FAILURE! - in MultibidSpec
Error:  PBS should prefer bidRequest over account level config [requestTargeting: org.prebid.server.functional.model.request.auction.Targeting{includeWinners:true, includeBidderKeys:false, preferDeals:true, alwaysIncludeDeals:false, includeFormat:false}, accountTargeting: org.prebid.server.functional.model.request.auction.Targeting{includeWinners:true, includeBidderKeys:false, preferDeals:true, alwaysIncludeDeals:false, includeFormat:false}, #2]  Time elapsed: 0.67 s  <<< FAILURE!
org.spockframework.runtime.ConditionNotSatisfiedError: 
Condition not satisfied:

bidderRequest.ext.prebid.targeting != accountTargeting
|             |   |      |         |  |
|             |   |      |         |  org.prebid.server.functional.model.request.auction.Targeting(includeWinners:true, includeBidderKeys:false, preferDeals:true, alwaysIncludeDeals:false, includeFormat:false)
|             |   |      |         false

@marki1an marki1an added the tests Functional or other tests label Jan 16, 2024
@marki1an marki1an self-assigned this Jan 16, 2024
Copy link
Collaborator

@Net-burst Net-burst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Net-burst Net-burst merged commit ed7da8c into master Jan 17, 2024
2 checks passed
@Net-burst Net-burst deleted the fix-flaky-tests-for-miltibid-spec branch January 17, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not port tests Functional or other tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants