Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add fix for multibidspec flaky tests #2906

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Tests: Add fix for multibidspec flaky tests #2906

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
281a2d3
Add fix for flaky tests
marki1an Jan 16, 2024
2117b04
Remove unused imports
marki1an Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/test/groovy/org/prebid/server/functional/tests/MultibidSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ class MultibidSpec extends BaseSpec {
requestTargeting | accountTargeting
Targeting.createWithAllValuesSetTo(true) | Targeting.createWithAllValuesSetTo(false)
Targeting.createWithAllValuesSetTo(false) | Targeting.createWithAllValuesSetTo(true)
Targeting.createWithRandomValues() | Targeting.createWithRandomValues()
}

def "PBS should use account level config when bidRequest does not have targeting settings"() {
Expand All @@ -115,6 +114,8 @@ class MultibidSpec extends BaseSpec {
assert bidderRequest.ext.prebid.targeting == account.config.auction.targeting

where:
accountTargeting << [Targeting.createWithAllValuesSetTo(false), Targeting.createWithAllValuesSetTo(true), Targeting.createWithRandomValues()]
accountTargeting << [Targeting.createWithAllValuesSetTo(false),
Targeting.createWithAllValuesSetTo(true),
Targeting.createWithRandomValues()]
}
}
Loading