AdView: support multi imps request & formattype tag for bid response #3355

AdviewOpen · 2023-12-15T01:07:59Z

support multi imps from request.
add formattype tag for bid response, use this to handle resp bid-type.

2.json format tidy up.

(2)add test codes for currency.

(2)test script re-fix.

2.add formattype tag for bid response, use this to handle resp bid-type.

Sonali-More-Xandr · 2024-01-23T06:34:50Z

adapters/adview/adview.go

+	// setting "banner" as the default bid type
+	bidType := openrtb_ext.BidTypeBanner
+	if bidExt != nil {
+		switch bidExt.BidType {


Please consider implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

Sorry, do you mean in line 203, bidType set to banner default type is not suitable, so I should return error if no matched bidtype, right?
Or you mean I should set Mtype such as "seatBid.Bid[i].MType = openrtb2.MarkupBanner" in MakeBids()?
Thank you.

@Sonali-More-Xandr So, you mean is I can use the following codes to get the bid type is enough?
func getMediaTypeForBid(bid openrtb2.Bid) (openrtb_ext.BidType, error) {
switch bid.MType {
case openrtb2.MarkupBanner:
return openrtb_ext.BidTypeBanner, nil
case openrtb2.MarkupVideo:
return openrtb_ext.BidTypeVideo, nil
case openrtb2.MarkupNative:
return openrtb_ext.BidTypeNative, nil
default:
return "", fmt.Errorf("Unable to fetch mediaType in: %s", bid.ImpID)
}
}

github-actions · 2024-01-25T05:58:43Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 188fcfc

adview

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/adview/adview.go:27:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:39:	MakeRequests		74.4%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:114:	MakeBids		90.9%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:161:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:166:	getMediaTypeForImp	0.0%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:181:	getMediaTypeForBid	81.8%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:201:	getBidType		87.5%
total:									(statements)		75.0%

github-actions · 2024-01-25T06:01:03Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, ed5fec3

adview

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/adview/adview.go:27:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:39:	MakeRequests		74.4%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:114:	MakeBids		90.9%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:161:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:166:	getMediaTypeForImp	0.0%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:181:	getMediaTypeForBid	66.7%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:197:	getBidType		0.0%
total:									(statements)		65.9%

AdviewOpen · 2024-01-25T06:11:42Z

Based on reviews, and I got the confirmation that adview server already support mtype in response, after test, i change getMediaTypeForBid(), pls review it.
Thanks.

onkarvhanumante · 2024-01-25T13:54:28Z

adapters/adview/adview.go

+		return "", fmt.Errorf("Unable to fetch mediaType in multi-format: %s", bid.ImpID)
+	}


@AdviewOpen should also add received mType in error case

Ok, add it.

github-actions · 2024-01-29T02:09:34Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 1d0d0f9

adview

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/adview/adview.go:27:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:39:	MakeRequests		74.4%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:114:	MakeBids		90.9%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:161:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:166:	getMediaTypeForImp	0.0%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:181:	getMediaTypeForBid	66.7%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:197:	getBidType		0.0%
total:									(statements)		65.9%

2.remove unused codes.

github-actions · 2024-01-29T02:11:28Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, d68ca53

adview

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/adview/adview.go:27:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:39:	MakeRequests		74.4%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:114:	MakeBids		90.9%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:161:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:166:	getMediaTypeForBid	66.7%
total:									(statements)		81.1%

github-actions · 2024-01-29T02:22:39Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 21372b8

adview

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/adview/adview.go:27:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:39:	MakeRequests		74.4%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:114:	MakeBids		90.9%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:161:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:166:	getMediaTypeForBid	66.7%
total:									(statements)		81.1%

AdviewOpen · 2024-01-29T02:35:47Z

Hi, I add mtype in error output & removed no used codes.
pls check it and thx.

onkarvhanumante · 2024-01-30T10:17:47Z

adapters/adview/adview.go

+		return openrtb_ext.BidTypeBanner, nil
+	case openrtb2.MarkupVideo:
+		return openrtb_ext.BidTypeVideo, nil
+	case openrtb2.MarkupAudio:


as per adview bidder-info yml, audio media type is not supported. should remove audio case

prebid-server/static/bidder-info/adview.yaml

Lines 9 to 12 in cd98554

mediaTypes:

- banner

- native

- video

Thanks for the reminder, fixed.

github-actions · 2024-01-31T02:06:48Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 2711af5

adview

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/adview/adview.go:27:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:39:	MakeRequests		74.4%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:114:	MakeBids		90.9%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:161:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:166:	getMediaTypeForBid	66.7%
total:									(statements)		81.1%

github-actions · 2024-01-31T02:14:38Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 57af4f6

adview

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/adview/adview.go:27:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:39:	MakeRequests		74.4%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:114:	MakeBids		90.9%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:161:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/adview/adview.go:166:	getMediaTypeForBid	80.0%
total:									(statements)		82.2%

AdviewOpen · 2024-01-31T02:27:44Z

Remove audio type cause not supporting now. thx.

bsardo · 2024-02-01T19:06:00Z

@AdviewOpen I didn't see a docs PR; can you open one please? Your documentation currently states that your adapter doesn’t support multi impression and can not perform impression splitting, so only the first impression will be delivered.

https://github.com/prebid/prebid.github.io/blob/5b17a6f67927ac955d9bda241bd0ec2c19fb7435/dev-docs/bidders/adview.md?plain=1#L25

AdviewOpen · 2024-02-02T03:49:52Z

We have update the doc PR #5126, Thanks again.

wildcat0601 and others added 30 commits August 30, 2021 11:25

adview adapter v1.0

dc07339

fix for review prebid#1982.

2121b66

fix format test json.

b8a4d78

recover ext in request to adview bid.

4b60aa1

remove invalid mediatype test

93fb6c7

remove tabs from codes

1dce3fa

tab issue fix.

a482d51

fix gofmt

cab079d

1.fixed error log process.

c426908

2.json format tidy up.

Merge branch 'master' of https://github.com/adview/prebid-server

048c8ef

Merge branch 'prebid:master' into master

de429fa

for adapter currency fix.

77747c7

(1)remove unused codes

ef9ab39

(2)add test codes for currency.

(1)add currency convert of request process.

9c9c479

(2)test script re-fix.

Merge branch 'prebid:master' into master

ef39579

add currency test case.

26e317d

just removed case.

9a26bcc

Merge branch 'prebid:master' into master

8228da0

add currency test script for new currency convert commit.

e985bcc

Merge branch 'prebid:master' into master

d016752

add gzip & modifyingVastXmlAllowed mode in yaml config.

adb5217

Merge branch 'prebid:master' into master

990ff0c

Merge branch 'prebid:master' into master

47e3856

Merge branch 'prebid:master' into master

1927653

Merge branch 'prebid:master' into master

8301a2f

1.support multi imps from request.

56ab374

2.add formattype tag for bid response, use this to handle resp bid-type.

fixes.

ec7ddf0

revert to older version codes.

fb078a1

fix2

62e2de8

fix3

8cccf08

Sonali-More-Xandr reviewed Jan 23, 2024

View reviewed changes

Merge branch 'prebid:master' into master

188fcfc

change getMediaTypeForBid(), use mtype to get bid type in response.

ed5fec3

AdviewOpen dismissed onkarvhanumante’s stale review via ed5fec3 January 25, 2024 06:00

onkarvhanumante reviewed Jan 25, 2024

View reviewed changes

Merge branch 'prebid:master' into master

1d0d0f9

1.add mtype in error case output.

d68ca53

2.remove unused codes.

gofmt it.

21372b8

onkarvhanumante reviewed Jan 30, 2024

View reviewed changes

Merge branch 'prebid:master' into master

2711af5

remove audio type cause not support now.

57af4f6

AdviewOpen requested review from onkarvhanumante and Sonali-More-Xandr February 1, 2024 01:31

Sonali-More-Xandr approved these changes Feb 1, 2024

View reviewed changes

onkarvhanumante approved these changes Feb 1, 2024

View reviewed changes

AdviewOpen mentioned this pull request Feb 2, 2024

AdView: support multi imps request, related to prebid-server adapter PR #3355 prebid/prebid.github.io#5126

Merged

8 tasks

onkarvhanumante merged commit 86bddad into prebid:master Feb 6, 2024
5 checks passed

cross-repo-issue-creation bot mentioned this pull request Feb 6, 2024

Port PR from PBS-Go: AdView: support multi imps request & formattype tag for bid response prebid/prebid-server-java#2952

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AdView: support multi imps request & formattype tag for bid response #3355

AdView: support multi imps request & formattype tag for bid response #3355

AdviewOpen commented Dec 15, 2023

Sonali-More-Xandr Jan 23, 2024

AdviewOpen Jan 24, 2024

AdviewOpen Jan 24, 2024

github-actions bot commented Jan 25, 2024

github-actions bot commented Jan 25, 2024

AdviewOpen commented Jan 25, 2024

onkarvhanumante Jan 25, 2024

AdviewOpen Jan 29, 2024

github-actions bot commented Jan 29, 2024

github-actions bot commented Jan 29, 2024

github-actions bot commented Jan 29, 2024

AdviewOpen commented Jan 29, 2024

onkarvhanumante Jan 30, 2024

AdviewOpen Jan 31, 2024

github-actions bot commented Jan 31, 2024

github-actions bot commented Jan 31, 2024

AdviewOpen commented Jan 31, 2024

bsardo commented Feb 1, 2024

AdviewOpen commented Feb 2, 2024

		return "", fmt.Errorf("Unable to fetch mediaType in multi-format: %s", bid.ImpID)
		}

AdView: support multi imps request & formattype tag for bid response #3355

AdView: support multi imps request & formattype tag for bid response #3355

Conversation

AdviewOpen commented Dec 15, 2023

Sonali-More-Xandr Jan 23, 2024

Choose a reason for hiding this comment

AdviewOpen Jan 24, 2024

Choose a reason for hiding this comment

AdviewOpen Jan 24, 2024

Choose a reason for hiding this comment

github-actions bot commented Jan 25, 2024

Code coverage summary

adview

github-actions bot commented Jan 25, 2024

Code coverage summary

adview

AdviewOpen commented Jan 25, 2024

onkarvhanumante Jan 25, 2024

Choose a reason for hiding this comment

AdviewOpen Jan 29, 2024

Choose a reason for hiding this comment

github-actions bot commented Jan 29, 2024

Code coverage summary

adview

github-actions bot commented Jan 29, 2024

Code coverage summary

adview

github-actions bot commented Jan 29, 2024

Code coverage summary

adview

AdviewOpen commented Jan 29, 2024

onkarvhanumante Jan 30, 2024

Choose a reason for hiding this comment

AdviewOpen Jan 31, 2024

Choose a reason for hiding this comment

github-actions bot commented Jan 31, 2024

Code coverage summary

adview

github-actions bot commented Jan 31, 2024

Code coverage summary

adview

AdviewOpen commented Jan 31, 2024

bsardo commented Feb 1, 2024

AdviewOpen commented Feb 2, 2024