Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Don't merge] ActionMenu: Remove width from stories #3958

Closed
wants to merge 2 commits into from

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Nov 20, 2023

Context: Almost all ActionMenu stories had a width on the Overlay, which is a bit odd because we also have a default auto width option that's more commonly used.

The snapshots in this PR also show how content doesn't always wrap properly in the default auto width!

Before After
image image
image image
image image

This comment was marked as resolved.

@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Nov 20, 2023
@siddharthkp siddharthkp self-assigned this Nov 20, 2023
Copy link
Contributor

github-actions bot commented Nov 20, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.25 KB (0%)
dist/browser.umd.js 104.79 KB (0%)

Copy link
Contributor

Uh oh! @siddharthkp, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

@siddharthkp siddharthkp deleted the actionmenu-see-auto-behavior branch December 7, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant