Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Don't merge] ActionMenu: Remove width from stories #3958

Closed
wants to merge 2 commits into from
Closed

[Don't merge] ActionMenu: Remove width from stories #3958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fcd965
ActionMenu: remove width from stories
siddharthkp Nov 20, 2023
0026099
test(vrt): update snapshots
siddharthkp Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ....test.ts-snapshots/ActionMenu-Groups-And-Descriptions-dark-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...Menu.test.ts-snapshots/ActionMenu-Groups-And-Descriptions-dark-dimmed-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...st.ts-snapshots/ActionMenu-Groups-And-Descriptions-dark-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../ActionMenu.test.ts-snapshots/ActionMenu-Groups-And-Descriptions-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ....test.ts-snapshots/ActionMenu-Groups-And-Descriptions-dark-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...test.ts-snapshots/ActionMenu-Groups-And-Descriptions-light-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...t.ts-snapshots/ActionMenu-Groups-And-Descriptions-light-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ActionMenu.test.ts-snapshots/ActionMenu-Groups-And-Descriptions-light-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...test.ts-snapshots/ActionMenu-Groups-And-Descriptions-light-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 6 additions & 6 deletions src/ActionMenu/ActionMenu.examples.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const GroupsAndDescriptions = () => {
<ActionMenu.Button variant="default" trailingVisual={GearIcon}>
Milestone
</ActionMenu.Button>
<ActionMenu.Overlay width="medium">
<ActionMenu.Overlay>
<ActionList selectionVariant="single" showDividers>
<ActionList.Group title="Open">
{milestones
Expand Down Expand Up @@ -82,7 +82,7 @@ export const CustomOverlayProps = () => {
<Box sx={{display: 'flex', justifyContent: 'center'}}>
<ActionMenu open={open} onOpenChange={setOpen}>
<ActionMenu.Button>Menu</ActionMenu.Button>
<ActionMenu.Overlay width="large" align="center">
<ActionMenu.Overlay align="center">
<ActionList>
<ActionList.Item>Option 1</ActionList.Item>
<ActionList.Item>Option 2</ActionList.Item>
Expand Down Expand Up @@ -161,7 +161,7 @@ export const CustomAnchor = () => (
<ActionMenu.Anchor>
<IconButton icon={KebabHorizontalIcon} aria-label="Open menu" />
</ActionMenu.Anchor>
<ActionMenu.Overlay width="medium">
<ActionMenu.Overlay>
<ActionList>
<ActionList.Item onSelect={() => alert('Copy link clicked')}>
Copy link
Expand Down Expand Up @@ -204,7 +204,7 @@ export const MixedSelection = () => {
<ActionMenu.Button leadingVisual={selectedOption ? selectedOption.icon : undefined}>
{selectedOption ? `Group by ${selectedOption.text}` : 'Group items by'}
</ActionMenu.Button>
<ActionMenu.Overlay width="medium">
<ActionMenu.Overlay>
<ActionList>
<ActionList.Group selectionVariant="single" title="Group by">
{options.map((option, index) => (
Expand Down Expand Up @@ -243,7 +243,7 @@ export const MultipleSections = () => {
<ActionMenu.Anchor>
<IconButton icon={KebabHorizontalIcon} aria-label="Open menu" />
</ActionMenu.Anchor>
<ActionMenu.Overlay width="small">
<ActionMenu.Overlay>
<ActionList>
<ActionList.Group title="Raw file content">
<ActionList.Item onSelect={() => alert('Workflows clicked')}>Download</ActionList.Item>
Expand Down Expand Up @@ -311,7 +311,7 @@ export const DelayedMenuClose = () => {
export const OnRightSide = () => (
<ActionMenu>
<ActionMenu.Button>Open menu</ActionMenu.Button>
<ActionMenu.Overlay width="medium" side="outside-right">
<ActionMenu.Overlay side="outside-right">
<ActionList>
<ActionList.Item onSelect={() => alert('Copy link clicked')}>
Copy link
Expand Down
6 changes: 3 additions & 3 deletions src/ActionMenu/ActionMenu.features.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default {
export const LinksAndActions = () => (
<ActionMenu>
<ActionMenu.Button>Open menu</ActionMenu.Button>
<ActionMenu.Overlay width="auto">
<ActionMenu.Overlay>
<ActionList>
<ActionList.Item onSelect={() => alert('Workflows clicked')}>
Workflows
Expand Down Expand Up @@ -76,7 +76,7 @@ export const SingleSelect = () => {
return (
<ActionMenu>
<ActionMenu.Button>Options: {selectedType.name}</ActionMenu.Button>
<ActionMenu.Overlay width="auto">
<ActionMenu.Overlay>
<ActionList selectionVariant="single">
{options.map((options, index) => (
<ActionList.Item key={index} selected={index === selectedIndex} onSelect={() => setSelectedIndex(index)}>
Expand Down Expand Up @@ -110,7 +110,7 @@ export const MultiSelect = () => {
return (
<ActionMenu>
<ActionMenu.Button>Display</ActionMenu.Button>
<ActionMenu.Overlay width="auto">
<ActionMenu.Overlay>
<ActionList selectionVariant="multiple">
{options.map(options => (
<ActionList.Item key={options.name} selected={options.selected} onSelect={() => toggle(options.name)}>
Expand Down
2 changes: 1 addition & 1 deletion src/ActionMenu/ActionMenu.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export default {
export const Default = () => (
<ActionMenu>
<ActionMenu.Button>Open menu</ActionMenu.Button>
<ActionMenu.Overlay width="medium">
<ActionMenu.Overlay>
<ActionList>
<ActionList.Item onSelect={() => alert('Copy link clicked')}>
Copy link
Expand Down
Loading