Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: restore deploy preview behavior #5536

Merged
merged 5 commits into from
Jan 13, 2025
Merged

revert: restore deploy preview behavior #5536

merged 5 commits into from
Jan 13, 2025

Conversation

joshblack
Copy link
Member

Investigating an issue where deploy previews are interacting with our official deploys to GitHub pages in an odd way 🤔 This PR reverts recent changes to these files so that we can re-apply them and figure out what's going on.

@joshblack joshblack requested a review from a team as a code owner January 13, 2025 18:34
@joshblack joshblack requested a review from jonrohan January 13, 2025 18:34
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: 31b2316

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Jan 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 13, 2025
@joshblack joshblack added the skip changeset This change does not need a changelog label Jan 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.18 KB (0%)
packages/react/dist/browser.umd.js 104.52 KB (0%)

@joshblack joshblack enabled auto-merge January 13, 2025 18:38
@joshblack joshblack added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit 15270ac Jan 13, 2025
43 of 44 checks passed
@joshblack joshblack deleted the chore/remove-deploy-previews branch January 13, 2025 18:51
hussam-i-am added a commit that referenced this pull request Jan 13, 2025
@hussam-i-am
Revert "revert: restore deploy preview behavior (#5536)"
ecd1f24 
This reverts commit 15270ac.
@hussam-i-am hussam-i-am mentioned this pull request Jan 13, 2025
Merged
13 tasks
github-merge-queue bot pushed a commit that referenced this pull request Jan 14, 2025
@hussam-i-am
Deploy preview with VRT/AAT reports (Take Two) (#5537)
4ababd8 
* Revert "revert: restore deploy preview behavior (#5536)"

This reverts commit 15270ac.

* Add pull_request check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hussam-i-am hussam-i-am hussam-i-am approved these changes

@jonrohan jonrohan jonrohan approved these changes

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @jonrohan @hussam-i-am