Clippy (beta)
11 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 11 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.67.0 (fc594f156 2023-01-24)
- cargo 1.67.0 (8ecd4f20a 2023-01-10)
- clippy 0.1.67 (fc594f1 2023-01-24)
Annotations
Check warning on line 266 in halo2_proofs/src/plonk/prover.rs
github-actions / Clippy (beta)
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2_proofs/src/plonk/prover.rs:266:18
|
266 | witness: Vec<Vec<Option<Vec<Assigned<Scheme::Scalar>>>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
Check warning on line 2061 in halo2_proofs/src/plonk/circuit.rs
github-actions / Clippy (beta)
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2_proofs/src/plonk/circuit.rs:2056:10
|
2056 | ) -> (
| __________^
2057 | | Queries,
2058 | | Vec<Gate<F>>,
2059 | | Vec<lookup::Argument<F>>,
2060 | | Vec<shuffle::Argument<F>>,
2061 | | ) {
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
Check warning on line 1938 in halo2_proofs/src/plonk/circuit.rs
github-actions / Clippy (beta)
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2_proofs/src/plonk/circuit.rs:1931:6
|
1931 | ) -> Result<
| ______^
1932 | | (
1933 | | CompiledCircuitV2<F>,
1934 | | ConcreteCircuit::Config,
... |
1937 | | Error,
1938 | | > {
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `-W clippy::type-complexity` implied by `-W clippy::all`
Check warning on line 891 in halo2_proofs/src/plonk/circuit.rs
github-actions / Clippy (beta)
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> halo2_proofs/src/plonk/circuit.rs:891:1
|
891 | impl<F> Into<ExpressionMid<F>> for Expression<F> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: replace the `Into` implentation with `From<plonk::circuit::Expression<F>>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `-W clippy::from-over-into` implied by `-W clippy::all`
Check warning on line 575 in halo2_proofs/tests/frontend_backend_split.rs
github-actions / Clippy (beta)
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> halo2_proofs/tests/frontend_backend_split.rs:575:9
|
575 | println!("phase {}", phase);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
help: change this to
|
575 - println!("phase {}", phase);
575 + println!("phase {phase}");
|
Check warning on line 507 in halo2_proofs/tests/frontend_backend_split.rs
github-actions / Clippy (beta)
redundant clone
warning: redundant clone
--> halo2_proofs/tests/frontend_backend_split.rs:507:18
|
507 | &[circuit.clone()],
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> halo2_proofs/tests/frontend_backend_split.rs:507:11
|
507 | &[circuit.clone()],
| ^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: `-W clippy::redundant-clone` implied by `-W clippy::all`
Check warning on line 62 in halo2_proofs/tests/frontend_backend_split.rs
github-actions / Clippy (beta)
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2_proofs/tests/frontend_backend_split.rs:62:10
|
62 | ) -> Result<(AssignedCell<F, F>, [AssignedCell<F, F>; 4]), Error> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `-W clippy::type-complexity` implied by `-W clippy::all`
Check warning on line 266 in halo2_proofs/src/plonk/prover.rs
github-actions / Clippy (beta)
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2_proofs/src/plonk/prover.rs:266:18
|
266 | witness: Vec<Vec<Option<Vec<Assigned<Scheme::Scalar>>>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
Check warning on line 2061 in halo2_proofs/src/plonk/circuit.rs
github-actions / Clippy (beta)
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2_proofs/src/plonk/circuit.rs:2056:10
|
2056 | ) -> (
| __________^
2057 | | Queries,
2058 | | Vec<Gate<F>>,
2059 | | Vec<lookup::Argument<F>>,
2060 | | Vec<shuffle::Argument<F>>,
2061 | | ) {
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
Check warning on line 1938 in halo2_proofs/src/plonk/circuit.rs
github-actions / Clippy (beta)
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2_proofs/src/plonk/circuit.rs:1931:6
|
1931 | ) -> Result<
| ______^
1932 | | (
1933 | | CompiledCircuitV2<F>,
1934 | | ConcreteCircuit::Config,
... |
1937 | | Error,
1938 | | > {
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `-W clippy::type-complexity` implied by `-W clippy::all`
Check warning on line 891 in halo2_proofs/src/plonk/circuit.rs
github-actions / Clippy (beta)
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> halo2_proofs/src/plonk/circuit.rs:891:1
|
891 | impl<F> Into<ExpressionMid<F>> for Expression<F> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: replace the `Into` implentation with `From<plonk::circuit::Expression<F>>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `-W clippy::from-over-into` implied by `-W clippy::all`