Skip to content

Address some of the review comments from @CPerezz

Sign in for the full log view
GitHub Actions / Clippy (1.56.1) failed Jan 15, 2024 in 1s

Clippy (1.56.1)

8 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 8
Warning 0
Note 0
Help 0

Versions

  • rustc 1.67.0 (fc594f156 2023-01-24)
  • cargo 1.67.0 (8ecd4f20a 2023-01-10)
  • clippy 0.1.67 (fc594f1 2023-01-24)

Annotations

Check failure on line 266 in halo2_proofs/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

very complex type used. Consider factoring parts into `type` definitions 

error: very complex type used. Consider factoring parts into `type` definitions
   --> halo2_proofs/src/plonk/prover.rs:266:18
    |
266 |         witness: Vec<Vec<Option<Vec<Assigned<Scheme::Scalar>>>>>,
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

Check failure on line 2061 in halo2_proofs/src/plonk/circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

very complex type used. Consider factoring parts into `type` definitions 

error: very complex type used. Consider factoring parts into `type` definitions
    --> halo2_proofs/src/plonk/circuit.rs:2056:10
     |
2056 |       ) -> (
     |  __________^
2057 | |         Queries,
2058 | |         Vec<Gate<F>>,
2059 | |         Vec<lookup::Argument<F>>,
2060 | |         Vec<shuffle::Argument<F>>,
2061 | |     ) {
     | |_____^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

Check failure on line 1938 in halo2_proofs/src/plonk/circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

very complex type used. Consider factoring parts into `type` definitions 

error: very complex type used. Consider factoring parts into `type` definitions
    --> halo2_proofs/src/plonk/circuit.rs:1931:6
     |
1931 |   ) -> Result<
     |  ______^
1932 | |     (
1933 | |         CompiledCircuitV2<F>,
1934 | |         ConcreteCircuit::Config,
...    |
1937 | |     Error,
1938 | | > {
     | |_^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
     = note: `-D clippy::type-complexity` implied by `-D warnings`

Check failure on line 891 in halo2_proofs/src/plonk/circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true 

error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> halo2_proofs/src/plonk/circuit.rs:891:1
    |
891 | impl<F> Into<ExpressionMid<F>> for Expression<F> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: replace the `Into` implentation with `From<plonk::circuit::Expression<F>>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
    = note: `-D clippy::from-over-into` implied by `-D warnings`

Check failure on line 266 in halo2_proofs/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

very complex type used. Consider factoring parts into `type` definitions 

error: very complex type used. Consider factoring parts into `type` definitions
   --> halo2_proofs/src/plonk/prover.rs:266:18
    |
266 |         witness: Vec<Vec<Option<Vec<Assigned<Scheme::Scalar>>>>>,
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

Check failure on line 2061 in halo2_proofs/src/plonk/circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

very complex type used. Consider factoring parts into `type` definitions 

error: very complex type used. Consider factoring parts into `type` definitions
    --> halo2_proofs/src/plonk/circuit.rs:2056:10
     |
2056 |       ) -> (
     |  __________^
2057 | |         Queries,
2058 | |         Vec<Gate<F>>,
2059 | |         Vec<lookup::Argument<F>>,
2060 | |         Vec<shuffle::Argument<F>>,
2061 | |     ) {
     | |_____^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

Check failure on line 1938 in halo2_proofs/src/plonk/circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

very complex type used. Consider factoring parts into `type` definitions 

error: very complex type used. Consider factoring parts into `type` definitions
    --> halo2_proofs/src/plonk/circuit.rs:1931:6
     |
1931 |   ) -> Result<
     |  ______^
1932 | |     (
1933 | |         CompiledCircuitV2<F>,
1934 | |         ConcreteCircuit::Config,
...    |
1937 | |     Error,
1938 | | > {
     | |_^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
     = note: `-D clippy::type-complexity` implied by `-D warnings`

Check failure on line 891 in halo2_proofs/src/plonk/circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true 

error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> halo2_proofs/src/plonk/circuit.rs:891:1
    |
891 | impl<F> Into<ExpressionMid<F>> for Expression<F> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: replace the `Into` implentation with `From<plonk::circuit::Expression<F>>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
    = note: `-D clippy::from-over-into` implied by `-D warnings`
View more details on GitHub Actions