feat: optimize deployment and tally event #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmad
added
documentation
✅ Deploy Preview for maci-typedoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
0xmad
force-pushed
the
feature/poll-event
branch
from
eea66aa to
5be0b71
Compare
0xmad
changed the title
0xmad
requested review from
ctrlc03,
kittybest,
samajammin and
crisgarner
as code owners
ctrlc03
requested changes
Jan 23, 2024
ctrlc03
force-pushed
the
feature/poll-event
branch
from
5be0b71 to
e5223f4
Compare
ctrlc03
force-pushed
the
feature/poll-event
branch
from
e5223f4 to
da94737
Compare
- [x] Update integration and cli docs - [x] Add poseidon contract addresses as cli arguments - [x] Add BallotsTallied(address) event for Tally contract - [x] Reuse already deployed poseidon contracts - [x] Use network to distingish contracts for different deployments
0xmad
force-pushed
the
feature/poll-event
branch
from
da94737 to
185b407
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional Notes
Storage layout (contracts) and file with contract addresses (cli) are changed
Related issue(s)
Closes #1054
Closes #1060
Closes #937
Confirmation