Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using a HTTPS catalog URL for arbitrary catalogs #11

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

simu
Copy link
Member

@simu simu commented Dec 17, 2024

This PR introduces logic which configures a Git insteadOf which injects the CI variables ACCESS_USER_<cluster_id> (which is optional and falls back to token if it's not set) and ACCESS_TOKEN_<cluster_id> (which must be present) for catalog URLs that are HTTPS on Lieutenant.

For example, the change will run the following git command for catalog URL "https://git.example.com/c-cluster-id-1234.git" for clustesr c-cluster-id-1234:

git config --global \
  url."https://${ACCESS_USER_c_cluster_id_1234:-token}:${ACCESS_TOKEN_c_cluster_id_1234}@git.example.com/c-cluster-id-1234.git".insteadOf \
  https://git.example.com/c-cluster-id-1234.git

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the following labels so it shows up
    in the correct changelog section:
    bug, enhancement, documentation, change, breaking, dependency, internal

@simu simu force-pushed the feat/https-catalog branch 2 times, most recently from 7e045d9 to b3f88d5 Compare December 17, 2024 10:28
@simu simu added the enhancement New feature or request label Dec 17, 2024
@simu simu force-pushed the feat/https-catalog branch from b3f88d5 to e6f1548 Compare December 17, 2024 10:37
@simu simu marked this pull request as ready for review December 17, 2024 10:44
@simu simu requested review from zugao and a team December 17, 2024 10:59
Copy link

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simu simu merged commit 64c9c6b into main Dec 18, 2024
8 checks passed
@simu simu deleted the feat/https-catalog branch December 18, 2024 10:28
@simu simu mentioned this pull request Dec 18, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants