Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sdkv2 detailed diff tests #2816

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Jan 7, 2025

This PR refactors the SDKv2 detailed diff tests to make test sharding easier. The main problem was that TestDetailedDiffSet was too large. Very similar to what #2814 does for PF.

This PR:

  • Moves the SDKv2 detailed diff tests to their own folder. This should make sharing code between them easier without exposing it to the other tests.
  • Splits up TestDetailedDiffSet into a few separate tests. This will allow the tests to be run on different shards.
  • Moves around some of the shared code into the value_makers.go file, instead of duplicating in each test.
  • Renames the tests to specify that they are for SDKv2 and renamed some of the utility functions to clarify what they do.

2c18440 has test recordings, the rest are the changes. The test recording changes are all no-ops related to the change in the struct being recorded.

@VenelinMartinov VenelinMartinov changed the base branch from vvm/test_sharding to vvm/refactor_pf_detailed_diff_tests January 7, 2025 16:13
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_detailed_diff_tests branch from 674db1c to 4f6a39f Compare January 7, 2025 16:13
@VenelinMartinov VenelinMartinov marked this pull request as draft January 7, 2025 16:18
@VenelinMartinov VenelinMartinov changed the title refactor sdkv2 detailed diff tests Refactor sdkv2 detailed diff tests Jan 7, 2025
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_detailed_diff_tests branch 2 times, most recently from 817019b to 2c18440 Compare January 7, 2025 17:16
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.70%. Comparing base (7bfd76b) to head (98c3684).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2816   +/-   ##
=======================================
  Coverage   68.70%   68.70%           
=======================================
  Files         325      325           
  Lines       41621    41621           
=======================================
  Hits        28595    28595           
  Misses      11419    11419           
  Partials     1607     1607           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov marked this pull request as ready for review January 7, 2025 18:47
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_pf_detailed_diff_tests branch from dbc1c2d to 8afea58 Compare January 13, 2025 12:04
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_detailed_diff_tests branch from 2c18440 to d36b425 Compare January 13, 2025 12:04
@VenelinMartinov VenelinMartinov requested a review from a team January 13, 2025 12:23
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_pf_detailed_diff_tests branch from 8afea58 to acc0f73 Compare January 13, 2025 13:37
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_detailed_diff_tests branch from d36b425 to 4da1a4c Compare January 13, 2025 13:37
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_pf_detailed_diff_tests branch from acc0f73 to 7aadd5d Compare January 13, 2025 15:30
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_detailed_diff_tests branch from 4da1a4c to bc0f627 Compare January 13, 2025 15:31
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_pf_detailed_diff_tests branch from 7aadd5d to 06d6bb1 Compare January 14, 2025 09:50
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_detailed_diff_tests branch from bc0f627 to a738145 Compare January 14, 2025 09:50
Base automatically changed from vvm/refactor_pf_detailed_diff_tests to master January 14, 2025 11:23
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_detailed_diff_tests branch from a738145 to 98c3684 Compare January 14, 2025 11:23
@VenelinMartinov VenelinMartinov enabled auto-merge (squash) January 14, 2025 11:24
@VenelinMartinov VenelinMartinov merged commit f68bff0 into master Jan 14, 2025
17 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/refactor_sdkv2_detailed_diff_tests branch January 14, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants