Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKv2 Diff tests for Map #2830

Merged
merged 2 commits into from
Jan 15, 2025
Merged

SDKv2 Diff tests for Map #2830

merged 2 commits into from
Jan 15, 2025

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Jan 14, 2025

This PR finishes the coverage of the SDKv2 bridge for Diff for Map types.

f2a0c1c contains the test recordings

fixes #2787

@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented Jan 14, 2025

This change is part of the following stack:

Change managed by git-spice.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.50%. Comparing base (9660285) to head (379450d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2830   +/-   ##
=======================================
  Coverage   67.49%   67.50%           
=======================================
  Files         325      325           
  Lines       41621    41621           
=======================================
+ Hits        28093    28095    +2     
+ Misses      11951    11948    -3     
- Partials     1577     1578    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_primitive branch from 3a114ca to 82a72f1 Compare January 14, 2025 11:38
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_test_map branch 2 times, most recently from 727543c to 9eee6e7 Compare January 14, 2025 12:09
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_primitive branch from 02d131f to 8789663 Compare January 14, 2025 13:03
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_test_map branch 3 times, most recently from 18d35fd to 7a1756c Compare January 14, 2025 15:23
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_primitive branch from 8789663 to ec47d3c Compare January 14, 2025 15:23
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_test_map branch from 7a1756c to 0a48b67 Compare January 14, 2025 15:23
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same response as the previous PR. Can we refactor the test block into it's own function? Duplicate (or worse - almost duplicate) code is very hard to maintain.

@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_primitive branch from ec47d3c to 6058e94 Compare January 15, 2025 11:46
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_test_map branch 2 times, most recently from 2dd1741 to 86c44b9 Compare January 15, 2025 12:01
Base automatically changed from vvm/sdkv2_diff_primitive to master January 15, 2025 12:18
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_test_map branch from 86c44b9 to 379450d Compare January 15, 2025 12:43
@VenelinMartinov VenelinMartinov enabled auto-merge (squash) January 15, 2025 12:49
@VenelinMartinov VenelinMartinov merged commit 8bb538e into master Jan 15, 2025
136 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/sdkv2_diff_test_map branch January 15, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDKv2 Test Map type in Diff
2 participants