-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDKv2 Diff tests for Map #2830
SDKv2 Diff tests for Map #2830
Conversation
This change is part of the following stack: Change managed by git-spice. |
f04108e
to
f2a0c1c
Compare
8552a4a
to
3a114ca
Compare
61c04a4
to
631abf1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2830 +/- ##
=======================================
Coverage 67.49% 67.50%
=======================================
Files 325 325
Lines 41621 41621
=======================================
+ Hits 28093 28095 +2
+ Misses 11951 11948 -3
- Partials 1577 1578 +1 ☔ View full report in Codecov by Sentry. |
3a114ca
to
82a72f1
Compare
727543c
to
9eee6e7
Compare
02d131f
to
8789663
Compare
18d35fd
to
7a1756c
Compare
8789663
to
ec47d3c
Compare
7a1756c
to
0a48b67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same response as the previous PR. Can we refactor the test block into it's own function? Duplicate (or worse - almost duplicate) code is very hard to maintain.
ec47d3c
to
6058e94
Compare
2dd1741
to
86c44b9
Compare
86c44b9
to
379450d
Compare
This PR finishes the coverage of the SDKv2 bridge for Diff for Map types.
f2a0c1c contains the test recordings
fixes #2787