Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKv2 Diff tests for Defaults in sets and lists #2838

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Jan 16, 2025

This PR adds Diff tests for Defaults in Set and List schemas. Note that the List and Set themselves can not have Defaults, since TF throws an error on these: Default is not valid for lists or sets.

Related to #2788
Related to #2789

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.48%. Comparing base (413419b) to head (1dcbb01).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2838      +/-   ##
==========================================
- Coverage   67.48%   67.48%   -0.01%     
==========================================
  Files         325      325              
  Lines       41633    41633              
==========================================
- Hits        28097    28094       -3     
- Misses      11957    11959       +2     
- Partials     1579     1580       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov force-pushed the refactor-set-and-list-diff-tests branch from 99e4bf3 to 97056b8 Compare January 17, 2025 15:46
@VenelinMartinov VenelinMartinov force-pushed the sdkv2-diff-tests-for-defaults-in branch from 6b7362c to 89d71db Compare January 17, 2025 15:46
@VenelinMartinov VenelinMartinov force-pushed the refactor-set-and-list-diff-tests branch from 97056b8 to f73e706 Compare January 17, 2025 16:38
@VenelinMartinov VenelinMartinov force-pushed the sdkv2-diff-tests-for-defaults-in branch from 89d71db to 188a68d Compare January 17, 2025 16:38
@iwahbe iwahbe self-requested a review January 17, 2025 17:07
@VenelinMartinov VenelinMartinov force-pushed the refactor-set-and-list-diff-tests branch from f73e706 to b961383 Compare January 17, 2025 17:08
@VenelinMartinov VenelinMartinov force-pushed the sdkv2-diff-tests-for-defaults-in branch from 188a68d to 5ab203a Compare January 17, 2025 17:08
Base automatically changed from refactor-set-and-list-diff-tests to master January 17, 2025 17:27
@VenelinMartinov VenelinMartinov force-pushed the sdkv2-diff-tests-for-defaults-in branch from 5ab203a to 1dcbb01 Compare January 17, 2025 17:43
@VenelinMartinov VenelinMartinov enabled auto-merge (squash) January 17, 2025 17:43
@VenelinMartinov VenelinMartinov merged commit 9357cbf into master Jan 17, 2025
71 checks passed
@VenelinMartinov VenelinMartinov deleted the sdkv2-diff-tests-for-defaults-in branch January 17, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants