Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKv2 Diff tests for MaxItemsOne sets #2839

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Jan 16, 2025

This PR adds Diff tests for MaxItemsOne sets for the SDKv2 bridge.

fixes #2789

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.48%. Comparing base (9357cbf) to head (94eb8b8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2839   +/-   ##
=======================================
  Coverage   67.48%   67.48%           
=======================================
  Files         325      325           
  Lines       41633    41633           
=======================================
  Hits        28097    28097           
  Misses      11957    11957           
  Partials     1579     1579           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov force-pushed the sdkv2-diff-tests-for-defaults-in branch from 6b7362c to 89d71db Compare January 17, 2025 15:46
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_tests_set_max_items_one branch from 3d2f4d3 to 0833d81 Compare January 17, 2025 15:46
@VenelinMartinov VenelinMartinov force-pushed the sdkv2-diff-tests-for-defaults-in branch from 89d71db to 188a68d Compare January 17, 2025 16:38
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_tests_set_max_items_one branch from 0833d81 to ae81ffb Compare January 17, 2025 16:38
@VenelinMartinov VenelinMartinov force-pushed the sdkv2-diff-tests-for-defaults-in branch from 188a68d to 5ab203a Compare January 17, 2025 17:08
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_tests_set_max_items_one branch from ae81ffb to b5bf725 Compare January 17, 2025 17:08
@VenelinMartinov VenelinMartinov force-pushed the sdkv2-diff-tests-for-defaults-in branch from 5ab203a to 1dcbb01 Compare January 17, 2025 17:43
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_tests_set_max_items_one branch from b5bf725 to 2dfadfe Compare January 17, 2025 17:43
Base automatically changed from sdkv2-diff-tests-for-defaults-in to master January 17, 2025 18:07
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_tests_set_max_items_one branch from 2dfadfe to 94eb8b8 Compare January 17, 2025 19:07
@VenelinMartinov VenelinMartinov enabled auto-merge (squash) January 17, 2025 19:07
@VenelinMartinov VenelinMartinov merged commit 3c7db4e into master Jan 17, 2025
71 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/sdkv2_diff_tests_set_max_items_one branch January 17, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDKv2 Test Set types in Diff
2 participants