Allow to set qBittorrent as default program

[glassez]

[glassez]

@qbittorrent/bug-handlers
Unfortunately, you can test it in real conditions only by building the installer. But you can reproduce this by clearing the registry from qBittorrent related entries and adding new ones manually or using the .reg file that I have been using since my first attempt to implement these changes 10 years ago (qbittorrent.reg.txt - remove .txt extension).

[sledgehammer999]

I have a local WIP branch on this issue too. Let me compare the two and give some feedback in a few hours.

[sledgehammer999]

My local branch was WIP because I was investigating some Win7 quirks and got bored. Now, I removed the half-measures for Win7 and I think it probably is fully functioning as-is for Win10+.

My branch is here. The relevant commit is this one.

I am almost certain that the installer/uninstaller stuff are fully functional. Comparing it to your PR, apart from the naming scheme differences, there are a couple extra registry keys that I write.
I do the registration on HKCU too. Probably to avoid any conflicts with another bt client that was installed only on the user-level and not machine wide. I can't remember what my tests had shown.

Finally, I can't remember if the changes in preferences.cpp are fully functional too. I tried to give some kind of "choice" to the user for file/url associations. A semblance of the old settings.

[sledgehammer999]

I do the registration on HKCU too. Probably to avoid any conflicts with another bt client that was installed only on the user-level and not machine wide. I can't remember what my tests had shown.

Another reason is, if the user runs qbt without using an installer they should be able to register it as default program.

[glassez]

I tried to give some kind of "choice" to the user for file/url associations.

That is, you suggest leaving the user the opportunity to register qBittorrent as torrent/magnet handlers, but setting it as a default program (if it is registered) will be available through Windows Settings, right? Hmm... it might make sense.

[stanlu1013]

Thanks. this reg file is awesome, fix my magnet link....

[glassez]

I believe that the current basic implementation will cover the needs of most "regular" users (who use the official installer and do not know anything about any profiles, portable modes, etc.). We should just start with it, and then try to extend it to cover more advanced use cases. Otherwise, this epic, which has been going on for about ten years, will not end.

[xavier2k6]

@glassez Strange one here.....went to test the builds & lt1 based build downloaded a-ok but lt2 based build gets flagged by windows defender & removed due to Trojan:Script/Wacatac.B!ml

I'm talking about the *-setup builds.

[glassez]

Strange one here.....went to test the builds & lt1 based build downloaded a-ok but lt2 based build gets flagged by windows defender & removed due to Trojan:Script/Wacatac.B!ml

I got a similar warning when I just tried to download the installer created in GHA CI for the first time. I just ignored it. The most interesting thing is that the fully downloaded file passes the test without any problems. I also sent it to VirusTotal. There are no problems found there either.

[xavier2k6]

Strange one here.....went to test the builds & lt1 based build downloaded a-ok but lt2 based build gets flagged by windows defender & removed due to Trojan:Script/Wacatac.B!ml

I got a similar warning when I just tried to download the installer created in GHA CI for the first time. I just ignored it. The most interesting thing is that the fully downloaded file passes the test without any problems. I also sent it to VirusTotal. There are no problems found there either.

Ya, seems to be a one off....probably due to files being new/less frequently downloaded....(false positive)

Anyway - I tested the Windows builds & could change associations, didn't observe any issues.

👍