Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow StandardRB to handle a V2 backend without a coupling map #1293

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

wshanks
Copy link
Collaborator

@wshanks wshanks commented Oct 27, 2023

StandardRB handles directed two-qubit gates differently from bi-directional ones. For BackendV2, it used the coupling_map to check for directionality but did not handle the case where the coupling map was None which implies all to all connectivity. With this change, StandardRB treats gates with no coupling map as bidirectional.

This issue first surfaced with qiskit-aer 0.13.0 which made AerSimulator a BackendV2 backend (#1292).

@wshanks wshanks added backport stable potential The issue or PR might be minimal and/or import enough to backport to stable Changelog: Bugfix Include in the "Fixed" section of the changelog labels Oct 27, 2023
@wshanks wshanks requested a review from itoko October 27, 2023 15:06
@wshanks
Copy link
Collaborator Author

wshanks commented Oct 27, 2023

I can add a release note, but I would like a reviewer to confirm that this is a good solution first.

Copy link
Contributor

@itoko itoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good solution for the quick fix while waiting for the merge of #1288, which may resolve the issue as a byproduct (but it would take some for the review).

@wshanks wshanks enabled auto-merge October 30, 2023 16:54
@wshanks wshanks added this pull request to the merge queue Oct 30, 2023
Merged via the queue into qiskit-community:main with commit a34df8c Oct 30, 2023
mergify bot pushed a commit that referenced this pull request Oct 30, 2023
`StandardRB` handles directed two-qubit gates differently from
bi-directional ones. For `BackendV2`, it used the `coupling_map` to
check for directionality but did not handle the case where the coupling
map was `None` which implies all to all connectivity. With this change,
`StandardRB` treats gates with no coupling map as bidirectional.

This issue first surfaced with qiskit-aer 0.13.0 which made
`AerSimulator` a `BackendV2` backend
(#1292).

(cherry picked from commit a34df8c)
wshanks pushed a commit that referenced this pull request Oct 31, 2023
…ort #1293) (#1298)

This is an automatic backport of pull request #1293 done by
[Mergify](https://mergify.com).

---

`StandardRB` handles directed two-qubit gates differently from
bi-directional ones. For `BackendV2`, it used the `coupling_map` to
check for directionality but did not handle the case where the coupling
map was `None` which implies all to all connectivity. With this change,
`StandardRB` treats gates with no coupling map as bidirectional.

This issue first surfaced with qiskit-aer 0.13.0 which made
`AerSimulator` a `BackendV2` backend
(#1292).
nkanazawa1989 pushed a commit to nkanazawa1989/qiskit-experiments that referenced this pull request Jan 17, 2024
…t-community#1293)

`StandardRB` handles directed two-qubit gates differently from
bi-directional ones. For `BackendV2`, it used the `coupling_map` to
check for directionality but did not handle the case where the coupling
map was `None` which implies all to all connectivity. With this change,
`StandardRB` treats gates with no coupling map as bidirectional.

This issue first surfaced with qiskit-aer 0.13.0 which made
`AerSimulator` a `BackendV2` backend
(qiskit-community#1292).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable potential The issue or PR might be minimal and/or import enough to backport to stable Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants