-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow StandardRB to handle a V2 backend without a coupling map #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wshanks
added
backport stable potential
The issue or PR might be minimal and/or import enough to backport to stable
Changelog: Bugfix
Include in the "Fixed" section of the changelog
labels
Oct 27, 2023
I can add a release note, but I would like a reviewer to confirm that this is a good solution first. |
This was referenced Oct 27, 2023
itoko
reviewed
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good solution for the quick fix while waiting for the merge of #1288, which may resolve the issue as a byproduct (but it would take some for the review).
coruscating
approved these changes
Oct 30, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
`StandardRB` handles directed two-qubit gates differently from bi-directional ones. For `BackendV2`, it used the `coupling_map` to check for directionality but did not handle the case where the coupling map was `None` which implies all to all connectivity. With this change, `StandardRB` treats gates with no coupling map as bidirectional. This issue first surfaced with qiskit-aer 0.13.0 which made `AerSimulator` a `BackendV2` backend (#1292). (cherry picked from commit a34df8c)
wshanks
pushed a commit
that referenced
this pull request
Oct 31, 2023
…ort #1293) (#1298) This is an automatic backport of pull request #1293 done by [Mergify](https://mergify.com). --- `StandardRB` handles directed two-qubit gates differently from bi-directional ones. For `BackendV2`, it used the `coupling_map` to check for directionality but did not handle the case where the coupling map was `None` which implies all to all connectivity. With this change, `StandardRB` treats gates with no coupling map as bidirectional. This issue first surfaced with qiskit-aer 0.13.0 which made `AerSimulator` a `BackendV2` backend (#1292).
nkanazawa1989
pushed a commit
to nkanazawa1989/qiskit-experiments
that referenced
this pull request
Jan 17, 2024
…t-community#1293) `StandardRB` handles directed two-qubit gates differently from bi-directional ones. For `BackendV2`, it used the `coupling_map` to check for directionality but did not handle the case where the coupling map was `None` which implies all to all connectivity. With this change, `StandardRB` treats gates with no coupling map as bidirectional. This issue first surfaced with qiskit-aer 0.13.0 which made `AerSimulator` a `BackendV2` backend (qiskit-community#1292).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport stable potential
The issue or PR might be minimal and/or import enough to backport to stable
Changelog: Bugfix
Include in the "Fixed" section of the changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StandardRB
handles directed two-qubit gates differently from bi-directional ones. ForBackendV2
, it used thecoupling_map
to check for directionality but did not handle the case where the coupling map wasNone
which implies all to all connectivity. With this change,StandardRB
treats gates with no coupling map as bidirectional.This issue first surfaced with qiskit-aer 0.13.0 which made
AerSimulator
aBackendV2
backend (#1292).