Add OperatorOpenShiftInfinispan anotation to setup Infinispan/datagrid on OpenShift
#1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalvavrik
requested changes
Jan 13, 2025
There was a problem hiding this comment.
I left comments, but I don't think any of that is important. What matters is - https://github.com/quarkus-qe/quarkus-test-suite/pull/2269/files makes changes to test with motivation described in the description of this PR:
In testsuite this was created in prestart phase of initialization of RestService which caused not cleaning up datagrid from openshift when the error occured while initialization of RestService.
honestly I have no means to verify this, I didn't see past runs nor I saw one run with changes in here that would prove it one way or another. I checked the code here one by line and it seems fine to me. I suggest we just merge it when you deal with my comments and test results will confirm @jedla97 conclusions then.
...t-service-infinispan/src/main/java/io/quarkus/test/bootstrap/DataGridInfinispanInstance.java
Outdated
Show resolved
Hide resolved
.../main/java/io/quarkus/test/bootstrap/service/datagrid/DataGridInfinispanManagedResource.java
Outdated
Show resolved
Hide resolved
.../main/java/io/quarkus/test/bootstrap/service/datagrid/DataGridInfinispanManagedResource.java
Outdated
Show resolved
Hide resolved
.../main/java/io/quarkus/test/bootstrap/service/datagrid/DataGridInfinispanManagedResource.java
Outdated
Show resolved
Hide resolved
.../main/java/io/quarkus/test/bootstrap/service/datagrid/DataGridInfinispanManagedResource.java
Outdated
Show resolved
Hide resolved
.../main/java/io/quarkus/test/bootstrap/service/datagrid/DataGridInfinispanManagedResource.java
Outdated
Show resolved
Hide resolved
...ava/io/quarkus/test/bootstrap/service/datagrid/DataGridInfinispanManagedResourceBuilder.java
Outdated
Show resolved
Hide resolved
.../main/java/io/quarkus/test/bootstrap/service/datagrid/DataGridInfinispanManagedResource.java
Outdated
Show resolved
Hide resolved
.../main/java/io/quarkus/test/bootstrap/service/datagrid/DataGridInfinispanManagedResource.java
Outdated
Show resolved
Hide resolved
.../main/java/io/quarkus/test/bootstrap/service/datagrid/DataGridInfinispanManagedResource.java
Outdated
Show resolved
Hide resolved
|
@jedla97 and PR title is also not good, please try something more explanatory |
This moving the logic from setting up the datagrid in testsuite to framework. In testsuite this was created in prestart phase of initialization of RestService which caused not cleaning up datagrid from openshift when the error occured while initialization of RestService. Usage ``` @DataGridInfinispan(clusterSecret = CLUSTER_SECRET, clusterConfig = CLUSTER_CONFIG, clusterConfigMap = CLUSTER_CONFIGMAP, connectSecret = CONNECT_SECRET, tlsSecret = TLS_SECRET) static DataGridInfinispanInstance dataGridInfinispan = new DataGridInfinispanInstance(); ``` Where `DataGridInfinispan` parameters mentioned above are mandatory. For real usage examle you can look at https://github.com/quarkus-qe/quarkus-test-suite/tree/main/infinispan-client
jedla97
force-pushed
the
datagrid-infinispan
branch
from
c4ebf1b to
c847cfb
Compare
jedla97
changed the title
OperatorOpenShiftInfinispan anotation to setup Infinispan/datagrid on OpenShift
|
I resolve comments. As I found that I need either change back the modified file or copy and modife them I choose later. With this it should be possible to run concurrently multiple infinispan cluster in one namespace. Also added the info about this "service" to wiki https://github.com/quarkus-qe/quarkus-test-framework/wiki/6.-Openshift#infinispandatagrid |
...a/io/quarkus/test/bootstrap/service/datagrid/OperatorOpenShiftInfinispanManagedResource.java
Show resolved
Hide resolved
michalvavrik
approved these changes
Jan 15, 2025
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This moving the logic from setting up the datagrid in testsuite to framework. In testsuite this was created in prestart phase of initialization of RestService which caused not cleaning up datagrid from openshift when the error occured while initialization of RestService.
This is mainly to use it with quarkus-qe/quarkus-test-suite#2269
Please check the relevant options
run testsphrase in comment)Checklist: