Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring the infinispan-client to use DataGridInfinispanInstance #2269

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Refactoring the infinispan-client to use DataGridInfinispanInstance #2269

merged 1 commit into from
Jan 17, 2025

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Jan 13, 2025 •
edited
Loading

Summary

The Infinispan/Datagrid cluster setup was moved to FW (quarkus-qe/quarkus-test-framework#1468). This PR:

  • Removing the setup of datagrid and not used method
  • Adding OperatorOpenShiftInfinispan as service
  • The killInfinispanCluster and restartInfinispanCluster stay because of testInvokeOnFailedInfinispanCluster. As this test try comunication when the cluster is down

The Path clusterConfigPath is using same mechanic to set path to file as in FW.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97 jedla97 mentioned this pull request Jan 13, 2025
Merged
11 tasks
@jedla97 jedla97 force-pushed the datagrid branch 2 times, most recently from ade89de to 9b37e13 Compare January 16, 2025 11:39
@jedla97
Refactoring the infinispan-client to use DataGridInfinispanInstance
3595c9e 
This is due to reason when the rest service fail the datagrid resources were not cleaned up.
@jedla97
Copy link
Member Author

jedla97 commented Jan 16, 2025

run tests

@jedla97 jedla97 marked this pull request as ready for review January 16, 2025 21:02
@jedla97 jedla97 requested a review from mocenas January 17, 2025 10:21
mocenas
mocenas approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@mocenas mocenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mocenas mocenas merged commit bb3ebe3 into quarkus-qe:main Jan 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mocenas mocenas mocenas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedla97 @mocenas