Add command to allow adding/changing/removing rcon password #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Like |
is-this-c
reviewed
Oct 17, 2024
is-this-c
reviewed
Oct 17, 2024
is-this-c
reviewed
Oct 17, 2024
rafalh
requested changes
Dec 10, 2024
|
|
||
| if (new_rcon_password) { | ||
| if (new_rcon_password->size() > 16) { | ||
| // game limits client requests to 16 characters |
There was a problem hiding this comment.
this comment is a bit wrong, the password is limited, not a "request" whatever that is
There was a problem hiding this comment.
I used the term "request" because the command is rcon_request
But I can change the comment.
| } | ||
|
|
||
| std::strncpy(rf::rcon_password, new_rcon_password->c_str(), sizeof(rf::rcon_password) - 1); | ||
| rf::rcon_password[sizeof(rf::rcon_password) - 1] = '\0'; // null terminator |
There was a problem hiding this comment.
what's the point of using strncpy and setting the null character manually if you validated the length. Simple std::strcpy would do the job just fine
| rf::console::print("Server rcon password set to: {}", rf::rcon_password); | ||
| } | ||
| else { | ||
| *rf::rcon_password = '\0'; |
There was a problem hiding this comment.
I would prefer rf::rcon_password[0] syntax - it's an array, not a generic pointer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
server_rcon_passwordcommand, which can be used to add an rcon password to a server without one, change the existing rcon password to something else, or remove the rcon password entirely.Syntax is
server_rcon_password <password>