-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command to allow adding/changing/removing rcon password #290
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,6 +92,34 @@ DcCommandAlias map_info_cmd{ | |
level_info_cmd, | ||
}; | ||
|
||
ConsoleCommand2 server_rcon_password_cmd{ | ||
"server_rcon_password", | ||
[](std::optional<std::string> new_rcon_password) { | ||
if (!rf::is_multi || !rf::is_dedicated_server) { | ||
rf::console::print("This command can only be run on a dedicated server!"); | ||
return; | ||
} | ||
|
||
if (new_rcon_password) { | ||
if (new_rcon_password->size() > 16) { | ||
// game limits client requests to 16 characters | ||
rf::console::print("Server rcon password cannot exceed 16 characters."); | ||
return; | ||
} | ||
|
||
std::strncpy(rf::rcon_password, new_rcon_password->c_str(), sizeof(rf::rcon_password) - 1); | ||
rf::rcon_password[sizeof(rf::rcon_password) - 1] = '\0'; // null terminator | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what's the point of using |
||
rf::console::print("Server rcon password set to: {}", rf::rcon_password); | ||
} | ||
else { | ||
*rf::rcon_password = '\0'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would prefer |
||
rf::console::print("Server rcon password removed."); | ||
} | ||
}, | ||
"Set or remove the server rcon password.", | ||
"server_rcon_password <password>", | ||
}; | ||
|
||
// only allow verify_level if a level is loaded (avoid a crash if command is run in menu) | ||
FunHook<void()> verify_level_cmd_hook{ | ||
0x0045E1F0, | ||
|
@@ -205,5 +233,6 @@ void console_commands_init() | |
map_cmd.register_cmd(); | ||
level_info_cmd.register_cmd(); | ||
map_info_cmd.register_cmd(); | ||
server_rcon_password_cmd.register_cmd(); | ||
verify_level_cmd_hook.install(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment is a bit wrong, the password is limited, not a "request" whatever that is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the term "request" because the command is
rcon_request
But I can change the comment.